From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
riegamaths@gmail.com
Subject: Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file
Date: Fri, 14 Sep 2012 08:45:18 +0100 [thread overview]
Message-ID: <20120914074518.GA25596@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <504F1129.8060009@redhat.com>
On Tue, Sep 11, 2012 at 12:23:37PM +0200, Kevin Wolf wrote:
> Am 05.09.2012 15:26, schrieb riegamaths@gmail.com:
> > From: Dunrong Huang <riegamaths@gmail.com>
> >
> > The caller would not delete temporary file after failed get_tmp_filename().
> >
> > Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
>
> Thanks, applied to the block branch.
For the record, using the close(2) errno after calling unlink(2) isn't
a good idea. We should follow the docs and preserve errno carefully.
It's the exact issue I pointed out on the original patch.
Stefan
prev parent reply other threads:[~2012-09-14 7:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 13:26 [Qemu-devel] [PATCH] block: Don't forget to delete temporary file riegamaths
2012-09-05 15:40 ` Paolo Bonzini
2012-09-05 15:51 ` Dunrong Huang
2012-09-05 16:02 ` Markus Armbruster
2012-09-05 16:23 ` Paolo Bonzini
2012-09-05 16:28 ` Eric Blake
2012-09-06 3:47 ` Dunrong Huang
2012-09-11 10:23 ` Kevin Wolf
2012-09-14 7:45 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914074518.GA25596@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riegamaths@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).