From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCUxM-0003ze-3F for qemu-devel@nongnu.org; Fri, 14 Sep 2012 08:25:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCUxB-0007n2-PK for qemu-devel@nongnu.org; Fri, 14 Sep 2012 08:25:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCUxB-0007ir-HS for qemu-devel@nongnu.org; Fri, 14 Sep 2012 08:25:01 -0400 Date: Fri, 14 Sep 2012 15:26:30 +0300 From: "Michael S. Tsirkin" Message-ID: <20120914122630.GE1490@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 11/25] q35: Introduce q35 pc based chipset emulator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: aliguori@us.ibm.com, alex.williamson@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, yamahata@valinux.co.jp, juzhang@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com On Thu, Sep 13, 2012 at 04:12:42PM -0400, Jason Baron wrote: > From: Isaku Yamahata > > pc q35 based chipset emulator to support pci express natively. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron I think it's best to smash the following patch into this one otherwise review becomes painful. Some short notes: > --- > hw/acpi_ich9.c | 315 ++++++++++++++++++ > hw/acpi_ich9.h | 53 +++ > hw/i386/Makefile.objs | 1 + > hw/pc_q35.c | 378 +++++++++++++++++++++ > hw/pci_ids.h | 14 + > hw/q35.c | 877 +++++++++++++++++++++++++++++++++++++++++++++++++ > hw/q35.h | 272 +++++++++++++++ > hw/q35_smbus.c | 154 +++++++++ > 8 files changed, 2064 insertions(+), 0 deletions(-) > create mode 100644 hw/acpi_ich9.c > create mode 100644 hw/acpi_ich9.h > create mode 100644 hw/pc_q35.c > create mode 100644 hw/q35.c > create mode 100644 hw/q35.h > create mode 100644 hw/q35_smbus.c > > diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c > new file mode 100644 > index 0000000..59c0807 > --- /dev/null > +++ b/hw/acpi_ich9.c > @@ -0,0 +1,315 @@ > +/* > + * ACPI implementation > + * > + * Copyright (c) 2006 Fabrice Bellard > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License version 2 as published by the Free Software Foundation. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, see > + */ > +/* > + * Copyright (c) 2009 Isaku Yamahata > + * VA Linux Systems Japan K.K. > + * Probably two headers should be combined. > + * This is based on acpi.c. This should probably go into commit log instead. > + */ .. > diff --git a/hw/acpi_ich9.h b/hw/acpi_ich9.h > new file mode 100644 > index 0000000..f55c0e9 > --- /dev/null > +++ b/hw/acpi_ich9.h > @@ -0,0 +1,53 @@ > +/* > + * QEMU GMCH/ICH9 LPC PM Emulation > + * > + * Copyright (c) 2009 Isaku Yamahata > + * VA Linux Systems Japan K.K. > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, see > + */ > + > +#ifndef HW_ACPI_ICH9_H > +#define HW_ACPI_ICH9_H > + > +#include "acpi.h" > + > +typedef struct ICH9_LPCPmRegs { This naming scheme conflicts with qemu coding style. Pls use Ich9LpcPmRegs or something. Same comment applies everywhere. -- MST