From: Mike Frysinger <vapier@gentoo.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] allow make {dist, }clean work w/out configure
Date: Sun, 16 Sep 2012 16:03:23 -0400 [thread overview]
Message-ID: <201209161603.24009.vapier@gentoo.org> (raw)
In-Reply-To: <5055A16F.4040303@redhat.com>
[-- Attachment #1: Type: Text/Plain, Size: 747 bytes --]
On Sunday 16 September 2012 05:52:47 Paolo Bonzini wrote:
> Il 16/09/2012 02:30, Mike Frysinger ha scritto:
> > There's no reason to require configure to run before running a clean
> > target, so check MAKECMDGOALS before.
> >
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -14,9 +14,11 @@ config-host.mak: $(SRC_PATH)/configure
> > @sed -n "/.*Configured with/s/[^:]*: //p" $@ | sh
> > else
> > config-host.mak:
> > +ifeq ($(findstring clean,$(MAKECMDGOALS)),)
>
> Please use instead:
>
> ifneq ($(filter-out %clean,$(MAKECMDGOALS)),)
>
> so that "make clean all" still gives error.
that breaks `make` though. or rather, `make` no longer errors out. need to
make it a little more complicated to handle this.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-16 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 0:30 [Qemu-devel] [PATCH] allow make {dist,}clean work w/out configure Mike Frysinger
2012-09-16 9:52 ` [Qemu-devel] [PATCH] allow make {dist, }clean " Paolo Bonzini
2012-09-16 20:03 ` Mike Frysinger [this message]
2012-09-17 7:55 ` Paolo Bonzini
2012-09-16 20:07 ` [Qemu-devel] [PATCH v2] " Mike Frysinger
2012-09-17 8:46 ` Paolo Bonzini
2012-10-19 19:32 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209161603.24009.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).