From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDL3o-0008MY-A1 for qemu-devel@nongnu.org; Sun, 16 Sep 2012 16:03:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDL3n-0002hu-Cc for qemu-devel@nongnu.org; Sun, 16 Sep 2012 16:03:20 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:45817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDL3n-0002h5-6M for qemu-devel@nongnu.org; Sun, 16 Sep 2012 16:03:19 -0400 From: Mike Frysinger Date: Sun, 16 Sep 2012 16:03:23 -0400 References: <1347755441-6499-1-git-send-email-vapier@gentoo.org> <5055A16F.4040303@redhat.com> In-Reply-To: <5055A16F.4040303@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart33722576.dZpuvoYcF8"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201209161603.24009.vapier@gentoo.org> Subject: Re: [Qemu-devel] [PATCH] allow make {dist, }clean work w/out configure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org --nextPart33722576.dZpuvoYcF8 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Sunday 16 September 2012 05:52:47 Paolo Bonzini wrote: > Il 16/09/2012 02:30, Mike Frysinger ha scritto: > > There's no reason to require configure to run before running a clean > > target, so check MAKECMDGOALS before. > >=20 > > --- a/Makefile > > +++ b/Makefile > > @@ -14,9 +14,11 @@ config-host.mak: $(SRC_PATH)/configure > > @sed -n "/.*Configured with/s/[^:]*: //p" $@ | sh > > else > > config-host.mak: > > +ifeq ($(findstring clean,$(MAKECMDGOALS)),) >=20 > Please use instead: >=20 > ifneq ($(filter-out %clean,$(MAKECMDGOALS)),) >=20 > so that "make clean all" still gives error. that breaks `make` though. or rather, `make` no longer errors out. need t= o=20 make it a little more complicated to handle this. =2Dmike --nextPart33722576.dZpuvoYcF8 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJQVjCLAAoJEEFjO5/oN/WBQ/oP/A3k+oLfXzlvjlRqiOrqmTwK fUcctLPSnMtdhyzFRX+VMzQthEqdjg43QBZMFxthvUcmmthh0HINRWPscF4of/QU /WnpUfJez32+CZtTmXa0ttnPIdRP/glAm1scOQdZzFLSdJ1Lw8yAtZZ4NlJZI+5v r0iQuBxuywEhKUl7FeNQUqymZzxcIeXRZoUdbTeEStyAB2BntTYtd3bElzJPHZoc vqmYP3kSXViiyrnD5LiE5y8Zcp/THHJlwEbSMJdnEV/2H8VbQsS1D6kQCAJPeOSF o3MEsRS/jRMAO7IK1+wmHElZWwrrOmLgkIkIpZ7rE+qaZXBTX1rQMJHAT/COWsDR lgFCS+5vo1K0I1E0SWCZd/qn+oHMWWClHleR2iTq9zJwSAYjp/LkjF+TrPQlgqDn KsaXIxH2fDw6slP55mDcdDg/p/n7d23Mkm90gJAIJX18xN6vmBKFP6Jn3c4WEEML Bz/BbwEr/ghibCHeEFVwJNdZv6PZYNA5CjYmS13pf4kqSs4FfT58MtNkRpvB7ePp dUeQGRsctjNbJR69V4a3K1IdIHL/jEnzy7ikGqlMCVH+BUSXB6hQICJeaqDqKlN5 cQu2hIJE/6WXFIIokUrrcng4nvJI63DUCfo5h4SuFXMIxXsLnlb2rE5Hb8SWiXCY pxWGL73Q7TcyCKJP653y =KR6z -----END PGP SIGNATURE----- --nextPart33722576.dZpuvoYcF8--