From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDxBz-0008VC-8u for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:46:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDxBt-0004tk-52 for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:46:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDxBs-0004sB-SW for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:46:13 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8ICkClh003733 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Sep 2012 08:46:12 -0400 Date: Tue, 18 Sep 2012 09:47:03 -0300 From: Luiz Capitulino Message-ID: <20120918094703.3130ab5a@doriath.home> In-Reply-To: <1347952634-12286-6-git-send-email-kraxel@redhat.com> References: <1347952634-12286-1-git-send-email-kraxel@redhat.com> <1347952634-12286-6-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/9] fbdev: add monitor command to enable/disable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Tue, 18 Sep 2012 09:17:10 +0200 Gerd Hoffmann wrote: > This patch adds a fbdev monitor command to enable/disable > the fbdev display at runtime to both qmp and hmp. > > qmp: fbdev enable=on|off > hmp: fbdev on|off > > Signed-off-by: Gerd Hoffmann > --- > hmp-commands.hx | 15 +++++++++++++++ > hmp.c | 9 +++++++++ > hmp.h | 1 + > qapi-schema.json | 14 ++++++++++++++ > qmp-commands.hx | 6 ++++++ > qmp.c | 17 +++++++++++++++++ > 6 files changed, 62 insertions(+), 0 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index ed67e99..366a92b 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1377,6 +1377,21 @@ passed since 1970, i.e. unix epoch. > ETEXI > > { > + .name = "fbdev", > + .args_type = "enable:b", > + .params = "on|off", > + .help = "enable/disable fbdev", > + .mhandler.cmd = hmp_fbdev, > + }, > + > +STEXI > +@item fbdev on | off > +@findex fbdev > + > +enable/disable fbdev > +ETEXI > + > + { > .name = "info", > .args_type = "item:s?", > .params = "[subcommand]", > diff --git a/hmp.c b/hmp.c > index ba6fbd3..a7feec5 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -1168,3 +1168,12 @@ void hmp_screen_dump(Monitor *mon, const QDict *qdict) > qmp_screendump(filename, &err); > hmp_handle_error(mon, &err); > } > + > +void hmp_fbdev(Monitor *mon, const QDict *qdict) > +{ > + int enable = qdict_get_bool(qdict, "enable"); > + Error *errp = NULL; > + > + qmp_fbdev(enable, &errp); > + hmp_handle_error(mon, &errp); > +} > diff --git a/hmp.h b/hmp.h > index 48b9c59..9c3d315 100644 > --- a/hmp.h > +++ b/hmp.h > @@ -73,5 +73,6 @@ void hmp_getfd(Monitor *mon, const QDict *qdict); > void hmp_closefd(Monitor *mon, const QDict *qdict); > void hmp_send_key(Monitor *mon, const QDict *qdict); > void hmp_screen_dump(Monitor *mon, const QDict *qdict); > +void hmp_fbdev(Monitor *mon, const QDict *qdict); > > #endif > diff --git a/qapi-schema.json b/qapi-schema.json > index 14e4419..901c2e8 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2619,3 +2619,17 @@ > # Since: 0.14.0 > ## > { 'command': 'screendump', 'data': {'filename': 'str'} } > + > +# @fbdev: Please, use more descriptive names for qmp. Maybe something like frame-buffer-device-add/-enable. > +# > +# Enable/disable fbdev. > +# > +# @enable: whenever fbdev should be enabled or disabled. > +# > +# Returns: Nothing on success > +# GenericError on failure. It's not needed to list GenericError as an error. > +# > +# Since: 1.3 > +# > +## > +{ 'command': 'fbdev', 'data': {'enable': 'bool'} } > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 6e21ddb..4b95fd0 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -2539,3 +2539,9 @@ EQMP > .args_type = "", > .mhandler.cmd_new = qmp_marshal_input_query_target, > }, > + > + { > + .name = "fbdev", > + .args_type = "enable:b", > + .mhandler.cmd_new = qmp_marshal_input_fbdev, > + }, > diff --git a/qmp.c b/qmp.c > index 8463922..7f6cc0b 100644 > --- a/qmp.c > +++ b/qmp.c > @@ -391,6 +391,23 @@ void qmp_change(const char *device, const char *target, > } > } > > +void qmp_fbdev(bool enable, Error **errp) > +{ > +#if defined(CONFIG_LINUX) > + DisplayState *ds = get_displaystate(); > + > + if (enable) { > + if (fbdev_display_init(ds, NULL) != 0) { > + error_setg(errp, "fbdev initialization failed"); Would be nice to tell the reason if you have it (error_setg() has printf()-likeformat). > + } > + } else { > + fbdev_display_uninit(ds); > + } > +#else > + error_set(errp, QERR_FEATURE_DISABLED, "fbdev"); We shouldn't use QERR_ macros in new code. You have two options: 1. use error_setg() 2. add error_set_disabled() in error.h, similar to error_setg(), and use it > +#endif > +} > + > static void qom_list_types_tramp(ObjectClass *klass, void *data) > { > ObjectTypeInfoList *e, **pret = data;