From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE3Kj-0002SB-EE for qemu-devel@nongnu.org; Tue, 18 Sep 2012 15:19:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE3Ki-0005HS-5q for qemu-devel@nongnu.org; Tue, 18 Sep 2012 15:19:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE3Kh-0005HK-RU for qemu-devel@nongnu.org; Tue, 18 Sep 2012 15:19:44 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8IJJhNs021901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Sep 2012 15:19:43 -0400 Date: Tue, 18 Sep 2012 16:20:34 -0300 From: Luiz Capitulino Message-ID: <20120918162034.4e416a1c@doriath.home> In-Reply-To: <5058C7CC.1030004@redhat.com> References: <20120918160652.48fe5baa@doriath.home> <5058C7CC.1030004@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qapi: convert add_client List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel On Tue, 18 Sep 2012 13:13:16 -0600 Eric Blake wrote: > On 09/18/2012 01:06 PM, Luiz Capitulino wrote: > > Also fixes a few issues while there: > > > > 1. The fd returned by monitor_get_fd() leaks in most error conditions > > 2. monitor_get_fd() return value is not checked. Best case we get > > an error that is not correctly reported, worse case one of the > > functions using the fd (with value of -1) will explode > > 3. A few error conditions aren't reported > > > > Signed-off-by: Luiz Capitulino > > --- > > monitor.c | 39 --------------------------------------- > > qapi-schema.json | 23 +++++++++++++++++++++++ > > qmp-commands.hx | 5 +---- > > qmp.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 68 insertions(+), 43 deletions(-) > > > > > { 'command': 'screendump', 'data': {'filename': 'str'} } > > + > > +## > > +# @add_client > > Are these supposed to be sorted in any particular order? Honestly, this is something I've paid very little attention to. But it's a good idea to keep the list sorted yes (although I'd like ErroClass to be the first item). > > > +# > > +# Allow client connections for VNC, Spice and socket based > > +# character devices to be passed in to QEMU via SCM_RIGHTS. > > +# > > +# @protocol: protocol name. Valid names are "vnc", "spice" or the > > +# name of a character device (eg. from -chardev id=XXXX) > > +# > > +# @fdname: file descriptor name passed via SCM_RIGHTS > > Misleading; isn't this really: > > file descriptor name previously passed via 'getfd' command > > since it is only 'getfd' that uses SCM_RIGHTS? You're right, of course. Stupid mistake from my part :) > > +# > > +# skipauth: #optional whether to skip authentication > > +# > > +# tls: #optional whether to perform TLS > > Missing leading @ on two lines. Will fix. > > +# > > +# Returns: nothing on success. > > +# > > +# Since: 0.14.0 > > If this were a new command for 1.3, I'd say to name it 'add-client'; but > since QMP has already been exposing it and you are now just documenting > it, you can't change the name. Yes, we just have to live with that for all old commands.