From: Aurelien Jarno <aurelien@aurel32.net>
To: Richard Henderson <rth@twiddle.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/5] tcg: movcond
Date: Tue, 18 Sep 2012 23:11:41 +0200 [thread overview]
Message-ID: <20120918211141.GA20705@ohm.aurel32.net> (raw)
In-Reply-To: <1347978240-20260-1-git-send-email-rth@twiddle.net>
On Tue, Sep 18, 2012 at 07:23:55AM -0700, Richard Henderson wrote:
> As recently discussed, with the optional fallback to setcond.
>
> I include a patch to target-alpha to test correctness both
> before and after implementing the opcode in the i386 backend,
> as well as in the optimizations.
>
Thanks for this new implementation, it's a lot cleaner than the previous
one, especially the fallback to setcond if not implemented, and the
argument alias for the x86 backend, deferring the issue to the register
allocator instead of trying to do that in the backend.
>From my side, I am ok with it. That said I'd also like to have at least
the opinion of Malc and Blue (Cc:ed). Comments from others are also
welcome.
>
> Richard Henderson (5):
> tcg: Introduce movcond
> target-alpha: Use movcond
> tcg-i386: Implement movcond
> tcg: Optimize movcond for constant comparisons
> tcg: Optimize two-address commutative operations
>
> target-alpha/translate.c | 102 ++++++++++++++++++++++-------------------------
> tcg/README | 6 +++
> tcg/arm/tcg-target.h | 1 +
> tcg/hppa/tcg-target.h | 1 +
> tcg/i386/tcg-target.c | 29 ++++++++++++++
> tcg/i386/tcg-target.h | 7 ++++
> tcg/ia64/tcg-target.h | 2 +
> tcg/mips/tcg-target.h | 1 +
> tcg/optimize.c | 49 ++++++++++++++++++++++-
> tcg/ppc/tcg-target.h | 1 +
> tcg/ppc64/tcg-target.h | 2 +
> tcg/s390/tcg-target.h | 2 +
> tcg/sparc/tcg-target.h | 2 +
> tcg/tcg-op.h | 41 +++++++++++++++++++
> tcg/tcg-opc.h | 2 +
> tcg/tcg.c | 11 +++--
> tcg/tcg.h | 1 +
> tcg/tci/tcg-target.h | 2 +
> 18 files changed, 200 insertions(+), 62 deletions(-)
>
> --
> 1.7.11.4
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-09-18 21:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 14:23 [Qemu-devel] [PATCH 0/5] tcg: movcond Richard Henderson
2012-09-18 14:23 ` [Qemu-devel] [PATCH 1/5] tcg: Introduce movcond Richard Henderson
2012-09-18 21:11 ` Aurelien Jarno
2012-09-20 22:06 ` Aurelien Jarno
2012-09-20 22:47 ` Richard Henderson
2012-09-18 14:23 ` [Qemu-devel] [PATCH 2/5] target-alpha: Use movcond Richard Henderson
2012-09-18 14:23 ` [Qemu-devel] [PATCH 3/5] tcg-i386: Implement movcond Richard Henderson
2012-09-18 21:11 ` Aurelien Jarno
2012-09-18 14:23 ` [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons Richard Henderson
2012-09-18 21:11 ` Aurelien Jarno
2012-09-20 22:04 ` Aurelien Jarno
2012-09-21 14:33 ` Richard Henderson
2012-09-21 14:52 ` Aurelien Jarno
2012-09-18 14:24 ` [Qemu-devel] [PATCH 5/5] tcg: Optimize two-address commutative operations Richard Henderson
2012-09-18 21:11 ` Aurelien Jarno
2012-09-18 21:11 ` Aurelien Jarno [this message]
2012-09-19 13:03 ` [Qemu-devel] [PATCH 0/5] tcg: movcond malc
2012-09-19 14:26 ` Richard Henderson
2012-09-19 19:07 ` Blue Swirl
2012-09-19 19:14 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918211141.GA20705@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).