From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE55D-0002Uy-8m for qemu-devel@nongnu.org; Tue, 18 Sep 2012 17:11:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE55C-0004WD-7A for qemu-devel@nongnu.org; Tue, 18 Sep 2012 17:11:51 -0400 Received: from hall.aurel32.net ([88.191.126.93]:59616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE55C-0004W8-11 for qemu-devel@nongnu.org; Tue, 18 Sep 2012 17:11:50 -0400 Date: Tue, 18 Sep 2012 23:11:48 +0200 From: Aurelien Jarno Message-ID: <20120918211148.GA20933@ohm.aurel32.net> References: <1347978240-20260-1-git-send-email-rth@twiddle.net> <1347978240-20260-5-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1347978240-20260-5-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Tue, Sep 18, 2012 at 07:23:59AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/optimize.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/tcg/optimize.c b/tcg/optimize.c > index fba0ed9..5b0a8ce 100644 > --- a/tcg/optimize.c > +++ b/tcg/optimize.c > @@ -397,6 +397,14 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, > args[3] = tcg_swap_cond(args[3]); > } > break; > + CASE_OP_32_64(movcond): > + if (temps[args[1]].state == TCG_TEMP_CONST > + && temps[args[2]].state != TCG_TEMP_CONST) { > + tmp = args[1]; > + args[1] = args[2]; > + args[2] = tmp; > + args[5] = tcg_swap_cond(args[5]); > + } > default: > break; > } > @@ -617,6 +625,27 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, > } > args += 4; > break; > + CASE_OP_33_64(movcond): > + if (temps[args[1]].state == TCG_TEMP_CONST > + && temps[args[2]].state == TCG_TEMP_CONST) { > + gen_opc_buf[op_index] = op_to_mov(op); > + tmp = do_constant_folding_cond(op, temps[args[1]].val, > + temps[args[2]].val, args[5]); > + tcg_opt_gen_mov(s, gen_args, args[0], args[4-tmp], > + nb_temps, nb_globals); > + gen_args += 2; > + } else { > + reset_temp(args[0], nb_temps, nb_globals); > + gen_args[0] = args[0]; > + gen_args[1] = args[1]; > + gen_args[2] = args[2]; > + gen_args[3] = args[3]; > + gen_args[4] = args[4]; > + gen_args[5] = args[5]; > + gen_args += 6; > + } > + args += 6; > + break; > case INDEX_op_call: > nb_call_args = (args[0] >> 16) + (args[0] & 0xffff); > if (!(args[nb_call_args + 1] & (TCG_CALL_CONST | TCG_CALL_PURE))) { > -- > 1.7.11.4 > Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net