From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TEKh1-0003zL-Ic
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 09:51:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TEKgv-0006aJ-Oh
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 09:51:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TEKgv-0006Zx-F7
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 09:51:49 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8JDpmgX015197
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 19 Sep 2012 09:51:48 -0400
Date: Wed, 19 Sep 2012 10:52:40 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120919105240.786aa432@doriath.home>
In-Reply-To: <87392eo5g1.fsf@blackfin.pond.sub.org>
References: <20120918160652.48fe5baa@doriath.home>
	<5058C7CC.1030004@redhat.com>
	<20120918162034.4e416a1c@doriath.home>
	<87392eo5g1.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qapi: convert add_client
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Wed, 19 Sep 2012 09:08:30 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > On Tue, 18 Sep 2012 13:13:16 -0600
> > Eric Blake <eblake@redhat.com> wrote:
> >
> >> On 09/18/2012 01:06 PM, Luiz Capitulino wrote:
> >> > Also fixes a few issues while there:
> >> > 
> >> >  1. The fd returned by monitor_get_fd() leaks in most error conditions
> >> >  2. monitor_get_fd() return value is not checked. Best case we get
> >> >     an error that is not correctly reported, worse case one of the
> >> >     functions using the fd (with value of -1) will explode
> >> >  3. A few error conditions aren't reported
> >> > 
> >> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> >> > ---
> >> >  monitor.c        | 39 ---------------------------------------
> >> >  qapi-schema.json | 23 +++++++++++++++++++++++
> >> >  qmp-commands.hx  |  5 +----
> >> >  qmp.c            | 44 ++++++++++++++++++++++++++++++++++++++++++++
> >> >  4 files changed, 68 insertions(+), 43 deletions(-)
> >> > 
> >> 
> >> >  { 'command': 'screendump', 'data': {'filename': 'str'} }
> >> > +
> >> > +##
> >> > +# @add_client
> [...]
> >> If this were a new command for 1.3, I'd say to name it 'add-client'; but
> >> since QMP has already been exposing it and you are now just documenting
> >> it, you can't change the name.
> >
> > Yes, we just have to live with that for all old commands.
> 
> If the inconsistency bothers us, we can either
> 
> * add suitable aliases for every QMP name containing '_', or
> 
> * fix the QMP names, and fold '_' to '-' in names received from client.

Agreed, maybe we could do both as some commands would profit from
having aliases (cont, qmp_capabilities, etc).