From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35768)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TEKlJ-0005QN-90
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 09:56:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TEKlD-0000aE-83
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 09:56:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52969)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TEKlC-0000Yh-VU
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 09:56:15 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8JDuEkY015074
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 19 Sep 2012 09:56:14 -0400
Date: Wed, 19 Sep 2012 10:57:06 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120919105706.65118649@doriath.home>
In-Reply-To: <5059A6B6.7010001@redhat.com>
References: <20120918160652.48fe5baa@doriath.home>
	<5059A6B6.7010001@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qapi: convert add_client
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Wed, 19 Sep 2012 13:04:22 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 18/09/2012 21:06, Luiz Capitulino ha scritto:
> > +    fd = monitor_get_fd(cur_mon, fdname);
> > +    if (fd < 0) {
> > +        error_setg(errp, "file-description '%s' has not been found", fdname);
> > +        return;
> > +    }
> 
> Please change this to add an Error * argument to monitor_get_fd, and
> change non-Error-friendly callers of monitor_get_fd to
> monitor_handle_fd_param.

Good point.

> You can then reuse the error in monitor_handle_fd_param (there is
> already QERR_FD_NOT_FOUND, by the way).
> 
> I'll post the patches later in my reviewed NBD series, please take them
> from there and I'll rebase before my pull request.

Ok, although I wouldn't mind having this patch on top of yours.