From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TELme-0003GA-OX for qemu-devel@nongnu.org; Wed, 19 Sep 2012 11:01:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TELmV-0005yz-0n for qemu-devel@nongnu.org; Wed, 19 Sep 2012 11:01:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TELmU-0005yh-No for qemu-devel@nongnu.org; Wed, 19 Sep 2012 11:01:38 -0400 Date: Wed, 19 Sep 2012 17:01:19 +0200 From: Igor Mammedov Message-ID: <20120919170119.6140e77b@nial.usersys.redhat.com> In-Reply-To: <20120913144008.GB18402@otherpad.lan.raisama.net> References: <1347051311-16122-1-git-send-email-imammedo@redhat.com> <1347051311-16122-3-git-send-email-imammedo@redhat.com> <20120913144008.GB18402@otherpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/22] target-i386: cpu_x86_register(): report error from property setter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, jan.kiszka@siemens.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, don.slutz@gmail.com, avi@redhat.com, pbonzini@redhat.com, lersek@redhat.com, afaerber@suse.de On Thu, 13 Sep 2012 11:40:08 -0300 Eduardo Habkost wrote: > On Fri, Sep 07, 2012 at 10:54:51PM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > target-i386/cpu.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index a89bdc4..3f80069 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -1415,6 +1415,7 @@ int cpu_x86_register(X86CPU *cpu, const char > > *cpu_model) > > out: > > if (error_is_set(&error)) { > > Isn't "if (error_is_set(&error)) better written as "if (error)"? > > There are lots of places where "error_is_set(&error)" is used, but I saw > other QEMU code using "if (error)" before, so I don't know what's the > recommended style. If there aren't any objections, I'll change it to suggested "if (error)" style, for the next respin. > > Anyway, the point of this patch is to add the error message, not > cleaning up the existing code. So: > > Reviewed-by: Eduardo Habkost > > > + fprintf(stderr, "%s\n", error_get_pretty(error)); > > error_free(error); > > return -1; > > } > > -- > > 1.7.11.4 > > > > >