From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50271)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1TEZka-0005lP-1k
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 01:56:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1TEZkY-0006p3-VW
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 01:56:35 -0400
Received: from e28smtp08.in.ibm.com ([122.248.162.8]:37752)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1TEZkY-0006o1-CA
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 01:56:34 -0400
Received: from /spool/local
	by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <bharata@linux.vnet.ibm.com>;
	Thu, 20 Sep 2012 11:26:28 +0530
Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q8K5u4Rs58458364
	for <qemu-devel@nongnu.org>; Thu, 20 Sep 2012 11:26:04 +0530
Received: from d28av03.in.ibm.com (loopback [127.0.0.1])
	by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q8K5u2Po001375
	for <qemu-devel@nongnu.org>; Thu, 20 Sep 2012 15:56:02 +1000
Date: Thu, 20 Sep 2012 11:27:54 +0530
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Message-ID: <20120920055754.GB5873@in.ibm.com>
References: <20120917152149.GB6879@in.ibm.com>
	<20120917152249.GC6879@in.ibm.com> <50586D7F.8060307@redhat.com>
	<50586FD7.6080206@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50586FD7.6080206@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non
	static.
Reply-To: bharata@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Anand Avati <aavati@redhat.com>, Vijay Bellur <vbellur@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Amar Tumballi <amarts@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>

On Tue, Sep 18, 2012 at 02:57:59PM +0200, Paolo Bonzini wrote:
> Il 18/09/2012 14:47, Kevin Wolf ha scritto:
> >> >  Makefile.objs  |    2 +-
> >> >  qemu-config.c  |   31 +++++++++++++++++++++++++++++++
> >> >  qemu-sockets.c |   42 ++++++------------------------------------
> >> >  qemu_socket.h  |    1 +
> >> >  4 files changed, 39 insertions(+), 37 deletions(-)
> > Making the option list global sounds fine, but I don't think it should
> > be moved to qemu-config.c or added to vm_config_groups, which is
> > generally used for command line options and config file entries. At
> > least I can't imagine a command line option -inet would be very useful.
> 
> Yes.  Also, I'll send a pull-request for
> http://patchwork.ozlabs.org/patch/180237/ soon, so you might as well
> take that patch.

Ok, this patch is good enough for gluster usecase. I will include this in my
v8 post if its not upstream by that time.

Regards,
Bharata.