From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56910)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <richard@daviesmail.org>) id 1TEzJ0-0002Ue-Q3
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 05:13:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <richard@daviesmail.org>) id 1TEzIw-00060s-OK
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 05:13:50 -0400
Received: from alpha.arachsys.com ([91.203.57.7]:53920)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <richard@daviesmail.org>) id 1TEzIw-00060o-IQ
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 05:13:46 -0400
Date: Fri, 21 Sep 2012 10:13:33 +0100
From: Richard Davies <richard@arachsys.com>
Message-ID: <20120921091333.GA32081@alpha.arachsys.com>
References: <1348149875-29678-1-git-send-email-mgorman@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1348149875-29678-1-git-send-email-mgorman@suse.de>
Subject: Re: [Qemu-devel] [PATCH 0/6] Reduce compaction scanning and lock
	contention
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mel Gorman <mgorman@suse.de>
Cc: KVM <kvm@vger.kernel.org>, QEMU-devel <qemu-devel@nongnu.org>, LKML <linux-kernel@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>, Avi Kivity <avi@redhat.com>, Shaohua Li <shli@kernel.org>

Hi Mel,

Thank you for this series. I have applied on clean 3.6-rc5 and tested, and
it works well for me - the lock contention is (still) gone and
isolate_freepages_block is much reduced.

Here is a typical test with these patches:

# grep -F '[k]' report | head -8
    65.20%         qemu-kvm  [kernel.kallsyms]     [k] clear_page_c
     2.18%         qemu-kvm  [kernel.kallsyms]     [k] isolate_freepages_block
     1.56%         qemu-kvm  [kernel.kallsyms]     [k] _raw_spin_lock
     1.40%         qemu-kvm  [kernel.kallsyms]     [k] svm_vcpu_run
     1.38%          swapper  [kernel.kallsyms]     [k] default_idle
     1.35%         qemu-kvm  [kernel.kallsyms]     [k] get_page_from_freelist
     0.74%             ksmd  [kernel.kallsyms]     [k] memcmp
     0.72%         qemu-kvm  [kernel.kallsyms]     [k] free_pages_prepare


I did manage to get a couple which were slightly worse, but nothing like as
bad as before. Here are the results:

# grep -F '[k]' report | head -8
    45.60%       qemu-kvm  [kernel.kallsyms]     [k] clear_page_c
    11.26%       qemu-kvm  [kernel.kallsyms]     [k] isolate_freepages_block
     3.21%       qemu-kvm  [kernel.kallsyms]     [k] _raw_spin_lock
     2.27%           ksmd  [kernel.kallsyms]     [k] memcmp
     2.02%        swapper  [kernel.kallsyms]     [k] default_idle
     1.58%       qemu-kvm  [kernel.kallsyms]     [k] svm_vcpu_run
     1.30%       qemu-kvm  [kernel.kallsyms]     [k] _raw_spin_lock_irqsave
     1.09%       qemu-kvm  [kernel.kallsyms]     [k] get_page_from_freelist

# grep -F '[k]' report | head -8
    61.29%       qemu-kvm  [kernel.kallsyms]     [k] clear_page_c
     4.52%       qemu-kvm  [kernel.kallsyms]     [k] _raw_spin_lock_irqsave
     2.64%       qemu-kvm  [kernel.kallsyms]     [k] copy_page_c
     1.61%        swapper  [kernel.kallsyms]     [k] default_idle
     1.57%       qemu-kvm  [kernel.kallsyms]     [k] _raw_spin_lock
     1.18%       qemu-kvm  [kernel.kallsyms]     [k] get_page_from_freelist
     1.18%       qemu-kvm  [kernel.kallsyms]     [k] isolate_freepages_block
     1.11%       qemu-kvm  [kernel.kallsyms]     [k] svm_vcpu_run

I will follow up with the detailed traces for these three tests.

Thank you!

Richard.