From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFAoo-0001ZK-R8 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 17:31:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFAon-0004gO-Qx for qemu-devel@nongnu.org; Fri, 21 Sep 2012 17:31:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFAon-0004gI-LD for qemu-devel@nongnu.org; Fri, 21 Sep 2012 17:31:25 -0400 Date: Fri, 21 Sep 2012 14:31:22 -0700 From: Andrew Morton Message-Id: <20120921143122.5be94b28.akpm@linux-foundation.org> In-Reply-To: <1348224383-1499-5-git-send-email-mgorman@suse.de> References: <1348224383-1499-1-git-send-email-mgorman@suse.de> <1348224383-1499-5-git-send-email-mgorman@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mel Gorman Cc: Richard Davies , KVM , QEMU-devel , LKML , Linux-MM , Avi Kivity , Shaohua Li On Fri, 21 Sep 2012 11:46:18 +0100 Mel Gorman wrote: > Changelog since V2 > o Fix BUG_ON triggered due to pages left on cc.migratepages > o Make compact_zone_order() require non-NULL arg `contended' > > Changelog since V1 > o only abort the compaction if lock is contended or run too long > o Rearranged the code by Andrea Arcangeli. > > isolate_migratepages_range() might isolate no pages if for example when > zone->lru_lock is contended and running asynchronous compaction. In this > case, we should abort compaction, otherwise, compact_zone will run a > useless loop and make zone->lru_lock is even contended. hm, this appears to be identical to mm-compaction-abort-compaction-loop-if-lock-is-contended-or-run-too-long.patch mm-compaction-abort-compaction-loop-if-lock-is-contended-or-run-too-long-fix.patch mm-compaction-abort-compaction-loop-if-lock-is-contended-or-run-too-long-fix-2.patch so I simply omitted patches 2, 3 and 4.