From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF4ab-0004UF-4q for qemu-devel@nongnu.org; Fri, 21 Sep 2012 10:52:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF4aW-00088o-Pt for qemu-devel@nongnu.org; Fri, 21 Sep 2012 10:52:21 -0400 Received: from hall.aurel32.net ([88.191.126.93]:34137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF4aW-00088U-Ix for qemu-devel@nongnu.org; Fri, 21 Sep 2012 10:52:16 -0400 Date: Fri, 21 Sep 2012 16:52:15 +0200 From: Aurelien Jarno Message-ID: <20120921145215.GE29951@hall.aurel32.net> References: <1347978240-20260-1-git-send-email-rth@twiddle.net> <1347978240-20260-5-git-send-email-rth@twiddle.net> <20120918211148.GA20933@ohm.aurel32.net> <20120920220419.GC4457@ohm.aurel32.net> <505C7AA4.9070800@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <505C7AA4.9070800@twiddle.net> Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Fri, Sep 21, 2012 at 07:33:08AM -0700, Richard Henderson wrote: > On 09/20/2012 03:04 PM, Aurelien Jarno wrote: > > + } else if (tmp && temps[args[4-tmp]].state == TCG_TEMP_CONST) { > > No need to test tmp here... Good catch, it's a leftover from a previous version. > But thanks for the patch. It'll be included in the next version. > Ok, great. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net