From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFR7Z-0000YO-Fz for qemu-devel@nongnu.org; Sat, 22 Sep 2012 10:55:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFR7V-00029m-8m for qemu-devel@nongnu.org; Sat, 22 Sep 2012 10:55:53 -0400 Received: from hall.aurel32.net ([88.191.126.93]:55799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFR7V-00028d-0R for qemu-devel@nongnu.org; Sat, 22 Sep 2012 10:55:49 -0400 Date: Sat, 22 Sep 2012 16:55:37 +0200 From: Aurelien Jarno Message-ID: <20120922145537.GA19755@ohm.aurel32.net> References: <1347557866-7256-1-git-send-email-sw@weilnetz.de> <1347557866-7256-3-git-send-email-sw@weilnetz.de> <20120913212157.GA840@ohm.aurel32.net> <5052507C.7010603@twiddle.net> <20120913214742.GC6791@ohm.aurel32.net> <50525C4B.4060604@twiddle.net> <5052BE19.90909@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <5052BE19.90909@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Blue Swirl , Peter Maydell , Alexander Graf , qemu-devel@nongnu.org, Richard Henderson On Fri, Sep 14, 2012 at 07:18:17AM +0200, Stefan Weil wrote: > Am 14.09.2012 00:20, schrieb Richard Henderson: > >On 09/13/2012 03:03 PM, Peter Maydell wrote: > >>Hard to come up with a snappy name for "register which is the Nth > >>input argument if input args are in registers, but an arbitrary > >>temp reg otherwise, and which is in the forbidden list for the L > >>constraint"... > >I'm more than happy to let "register which is ..." be a comment > >just before the definitions of TCG_REG_Ln at the top... > > > > > > > >r~ > > > > This looks like a pragmatic solution. > > If everybody agrees, I'll send an updated patch. > > Or Aurelien or Blue can commit this series and fix the comment > as suggested by Richard. Maybe a comment in theprologue code > would also be good. > > Thanks to all reviewers. > Your patch didn't even compiled on i386. I have fixed it. I also changed the prologue on i386 to not load the TB address through a register, given i386 has so many addressing mode. This way the issue is solved. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net