From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFRfZ-0003Xe-Sc for qemu-devel@nongnu.org; Sat, 22 Sep 2012 11:31:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFRfY-0006rJ-OG for qemu-devel@nongnu.org; Sat, 22 Sep 2012 11:31:01 -0400 Date: Sat, 22 Sep 2012 16:30:55 +0100 From: Stefan Hajnoczi Message-ID: <20120922153055.GC13216@stefanha-thinkpad.localdomain> References: <1346490743-9652-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1346490743-9652-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] cadence_uart: Fix buffer overflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Peter Crosthwaite , qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Sat, Sep 01, 2012 at 11:12:23AM +0200, Stefan Weil wrote: > Report from smatch: > hw/cadence_uart.c:413 uart_read(13) error: buffer overflow 's->r' 18 <= 18 > > This fixes read access to s->r[R_MAX] which is behind the limits of s->r. > > Signed-off-by: Stefan Weil > --- > hw/cadence_uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan