From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFRsM-0007gD-Ir for qemu-devel@nongnu.org; Sat, 22 Sep 2012 11:44:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFRsL-0003k6-N5 for qemu-devel@nongnu.org; Sat, 22 Sep 2012 11:44:14 -0400 Date: Sat, 22 Sep 2012 16:44:08 +0100 From: Stefan Hajnoczi Message-ID: <20120922154408.GF13216@stefanha-thinkpad.localdomain> References: <1346497248-14659-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1346497248-14659-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash_cfi01: Fix warning caused by unreachable code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Sat, Sep 01, 2012 at 01:00:48PM +0200, Stefan Weil wrote: > Report from smatch: > hw/pflash_cfi01.c:431 pflash_write(180) info: ignoring unreachable code. > > Instead of removing the return statement after the switch statement, > the patch replaces the return statements in the switch statement by > break statements. Other switch statements in the same code do it also > like that. > > Signed-off-by: Stefan Weil > --- > hw/pflash_cfi01.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan