From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58019)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TFVkE-0004jM-UR
	for qemu-devel@nongnu.org; Sat, 22 Sep 2012 15:52:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TFVkD-0002Wd-2B
	for qemu-devel@nongnu.org; Sat, 22 Sep 2012 15:52:06 -0400
Received: from hall.aurel32.net ([88.191.126.93]:41468)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TFVkC-0002WT-Q0
	for qemu-devel@nongnu.org; Sat, 22 Sep 2012 15:52:04 -0400
Date: Sat, 22 Sep 2012 21:52:02 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20120922195202.GA32297@ohm.aurel32.net>
References: <1348273096-1495-1-git-send-email-rth@twiddle.net>
	<1348273096-1495-4-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1348273096-1495-4-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 3/8] tcg: Optimize initial inputs for
	ori_i64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Fri, Sep 21, 2012 at 05:18:11PM -0700, Richard Henderson wrote:
> Copy the same optimizations from ori_i32.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/tcg-op.h | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
> index c8633ff..fd16499 100644
> --- a/tcg/tcg-op.h
> +++ b/tcg/tcg-op.h
> @@ -559,9 +559,9 @@ static inline void tcg_gen_or_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2)
>  
>  static inline void tcg_gen_ori_i32(TCGv_i32 ret, TCGv_i32 arg1, int32_t arg2)
>  {
> -    /* some cases can be optimized here */
> -    if (arg2 == 0xffffffff) {
> -        tcg_gen_movi_i32(ret, 0xffffffff);
> +    /* Some cases can be optimized here.  */
> +    if (arg2 == -1) {
> +        tcg_gen_movi_i32(ret, -1);
>      } else if (arg2 == 0) {
>          tcg_gen_mov_i32(ret, arg1);
>      } else {
> @@ -1183,9 +1183,16 @@ static inline void tcg_gen_or_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2)
>  
>  static inline void tcg_gen_ori_i64(TCGv_i64 ret, TCGv_i64 arg1, int64_t arg2)
>  {
> -    TCGv_i64 t0 = tcg_const_i64(arg2);
> -    tcg_gen_or_i64(ret, arg1, t0);
> -    tcg_temp_free_i64(t0);
> +    /* Some cases can be optimized here.  */
> +    if (arg2 == -1) {
> +        tcg_gen_movi_i64(ret, -1);
> +    } else if (arg2 == 0) {
> +        tcg_gen_mov_i64(ret, arg1);
> +    } else {
> +        TCGv_i64 t0 = tcg_const_i64(arg2);
> +        tcg_gen_or_i64(ret, arg1, t0);
> +        tcg_temp_free_i64(t0);
> +    }
>  }
>  
>  static inline void tcg_gen_xor_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2)
> -- 
> 1.7.11.4
> 

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net