From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFVkG-0004jZ-9a for qemu-devel@nongnu.org; Sat, 22 Sep 2012 15:52:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFVkE-0002X0-Rm for qemu-devel@nongnu.org; Sat, 22 Sep 2012 15:52:08 -0400 Received: from hall.aurel32.net ([88.191.126.93]:41471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFVkE-0002Wp-In for qemu-devel@nongnu.org; Sat, 22 Sep 2012 15:52:06 -0400 Date: Sat, 22 Sep 2012 21:52:04 +0200 From: Aurelien Jarno Message-ID: <20120922195204.GA32354@ohm.aurel32.net> References: <1348273096-1495-1-git-send-email-rth@twiddle.net> <1348273096-1495-5-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1348273096-1495-5-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 4/8] tcg: Emit XORI as NOT for appropriate constants List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Fri, Sep 21, 2012 at 05:18:12PM -0700, Richard Henderson wrote: > Note that xori_i64 failed to perform even the minimal > optimizations promised by the README. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.h | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h > index fd16499..bcfb60b 100644 > --- a/tcg/tcg-op.h > +++ b/tcg/tcg-op.h > @@ -582,9 +582,12 @@ static inline void tcg_gen_xor_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2) > > static inline void tcg_gen_xori_i32(TCGv_i32 ret, TCGv_i32 arg1, int32_t arg2) > { > - /* some cases can be optimized here */ > + /* Some cases can be optimized here. */ > if (arg2 == 0) { > tcg_gen_mov_i32(ret, arg1); > + } else if (arg2 == -1 && TCG_TARGET_HAS_not_i32) { > + /* Don't recurse with tcg_gen_not_i32. */ > + tcg_gen_op2_i32(INDEX_op_not_i32, ret, arg1); > } else { > TCGv_i32 t0 = tcg_const_i32(arg2); > tcg_gen_xor_i32(ret, arg1, t0); > @@ -1206,9 +1209,17 @@ static inline void tcg_gen_xor_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2) > > static inline void tcg_gen_xori_i64(TCGv_i64 ret, TCGv_i64 arg1, int64_t arg2) > { > - TCGv_i64 t0 = tcg_const_i64(arg2); > - tcg_gen_xor_i64(ret, arg1, t0); > - tcg_temp_free_i64(t0); > + /* Some cases can be optimized here. */ > + if (arg2 == 0) { > + tcg_gen_mov_i64(ret, arg1); > + } else if (arg2 == -1 && TCG_TARGET_HAS_not_i64) { > + /* Don't recurse with tcg_gen_not_i64. */ > + tcg_gen_op2_i64(INDEX_op_not_i64, ret, arg1); > + } else { > + TCGv_i64 t0 = tcg_const_i64(arg2); > + tcg_gen_xor_i64(ret, arg1, t0); > + tcg_temp_free_i64(t0); > + } > } > > static inline void tcg_gen_shl_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2) > -- > 1.7.11.4 > Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net