From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: Remove redundant null check and replace free by g_free
Date: Sun, 23 Sep 2012 07:35:52 +0100 [thread overview]
Message-ID: <20120923063552.GA7348@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1346789659-6824-1-git-send-email-sw@weilnetz.de>
On Tue, Sep 04, 2012 at 10:14:19PM +0200, Stefan Weil wrote:
> Report from smatch:
>
> linux-user/syscall.c:3632 do_ioctl_dm(220) info:
> redundant null check on big_buf calling free()
>
> 'big_buf' was allocated by g_malloc0, therefore free was also
> replaced by g_free.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> linux-user/syscall.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2012-09-23 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 20:14 [Qemu-devel] [PATCH] linux-user: Remove redundant null check and replace free by g_free Stefan Weil
2012-09-04 20:40 ` Peter Maydell
2012-09-22 21:28 ` Stefan Weil
2012-09-23 6:35 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120923063552.GA7348@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).