From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFfnK-0001Yr-2U for qemu-devel@nongnu.org; Sun, 23 Sep 2012 02:35:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFfnJ-0002vq-0a for qemu-devel@nongnu.org; Sun, 23 Sep 2012 02:35:57 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:56715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFfnI-0002vm-PV for qemu-devel@nongnu.org; Sun, 23 Sep 2012 02:35:56 -0400 Received: by wgbdr1 with SMTP id dr1so3023454wgb.10 for ; Sat, 22 Sep 2012 23:35:54 -0700 (PDT) Date: Sun, 23 Sep 2012 07:35:52 +0100 From: Stefan Hajnoczi Message-ID: <20120923063552.GA7348@stefanha-thinkpad.localdomain> References: <1346789659-6824-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1346789659-6824-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH] linux-user: Remove redundant null check and replace free by g_free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Riku Voipio , qemu-devel@nongnu.org On Tue, Sep 04, 2012 at 10:14:19PM +0200, Stefan Weil wrote: > Report from smatch: > > linux-user/syscall.c:3632 do_ioctl_dm(220) info: > redundant null check on big_buf calling free() > > 'big_buf' was allocated by g_malloc0, therefore free was also > replaced by g_free. > > Signed-off-by: Stefan Weil > --- > linux-user/syscall.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan