From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] net/socket: Fix compiler warning (regression for MinGW)
Date: Sun, 23 Sep 2012 07:37:50 +0100 [thread overview]
Message-ID: <20120923063750.GA7597@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1348341208-23260-1-git-send-email-sw@weilnetz.de>
On Sat, Sep 22, 2012 at 09:13:28PM +0200, Stefan Weil wrote:
> Commit 213fd5087e2e4e2da10ad266df0ba950cf7618bf removed a type cast
> which is needed for MinGW:
>
> net/socket.c:136: warning:
> pointer targets in passing argument 2 of ‘sendto’ differ in signedness
> /usr/lib/gcc/amd64-mingw32msvc/4.4.4/../../../../amd64-mingw32msvc/include/winsock2.h:1313: note:
> expected ‘const char *’ but argument is of type ‘const uint8_t *’
>
> Add a 'qemu_sendto' macro which provides that type cast where needed
> and use the new macro instead of 'sendto'.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> I hope the modifications are trivial enough to justify that I did not
> split this in two patches.
>
> Regards
>
> Stefan W.
>
> net/socket.c | 6 +++---
> qemu-common.h | 5 +++++
> 2 files changed, 8 insertions(+), 3 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
next prev parent reply other threads:[~2012-09-23 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-22 19:13 [Qemu-devel] [PATCH] net/socket: Fix compiler warning (regression for MinGW) Stefan Weil
2012-09-23 6:37 ` Stefan Hajnoczi [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-20 19:32 Stefan Weil
2012-09-22 16:32 ` Stefan Hajnoczi
2012-09-22 18:01 ` Michael Tokarev
2012-09-22 18:17 ` Stefan Weil
2012-09-22 18:25 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120923063750.GA7597@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).