From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFfpC-0002KD-Qv for qemu-devel@nongnu.org; Sun, 23 Sep 2012 02:37:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFfpB-0003Ey-Ly for qemu-devel@nongnu.org; Sun, 23 Sep 2012 02:37:54 -0400 Date: Sun, 23 Sep 2012 07:37:50 +0100 From: Stefan Hajnoczi Message-ID: <20120923063750.GA7597@stefanha-thinkpad.localdomain> References: <1348341208-23260-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1348341208-23260-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH] net/socket: Fix compiler warning (regression for MinGW) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Blue Swirl , qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Sat, Sep 22, 2012 at 09:13:28PM +0200, Stefan Weil wrote: > Commit 213fd5087e2e4e2da10ad266df0ba950cf7618bf removed a type cast > which is needed for MinGW: > > net/socket.c:136: warning: > pointer targets in passing argument 2 of ‘sendto’ differ in signedness > /usr/lib/gcc/amd64-mingw32msvc/4.4.4/../../../../amd64-mingw32msvc/include/winsock2.h:1313: note: > expected ‘const char *’ but argument is of type ‘const uint8_t *’ > > Add a 'qemu_sendto' macro which provides that type cast where needed > and use the new macro instead of 'sendto'. > > Signed-off-by: Stefan Weil > --- > > I hope the modifications are trivial enough to justify that I did not > split this in two patches. > > Regards > > Stefan W. > > net/socket.c | 6 +++--- > qemu-common.h | 5 +++++ > 2 files changed, 8 insertions(+), 3 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan