From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TFfqs-00038u-At
	for qemu-devel@nongnu.org; Sun, 23 Sep 2012 02:39:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TFfqr-0003PT-Ae
	for qemu-devel@nongnu.org; Sun, 23 Sep 2012 02:39:38 -0400
Received: from mail-wi0-f181.google.com ([209.85.212.181]:46818)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TFfqr-0003PP-4Q
	for qemu-devel@nongnu.org; Sun, 23 Sep 2012 02:39:37 -0400
Received: by wibhq12 with SMTP id hq12so46222wib.10
	for <qemu-devel@nongnu.org>; Sat, 22 Sep 2012 23:39:36 -0700 (PDT)
Date: Sun, 23 Sep 2012 07:39:34 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20120923063934.GA7684@stefanha-thinkpad.localdomain>
References: <1345664552-2250-1-git-send-email-sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1345664552-2250-1-git-send-email-sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH] w32: Always use standard instead of native
 format strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On Wed, Aug 22, 2012 at 09:42:32PM +0200, Stefan Weil wrote:
> GLib 2.0 include files use __printf__ for the format attribute
> which resolves to native format strings on w32 hosts.
> 
> QEMU wants standard format strings instead of native format
> strings, so we simply change any declaration with __printf__
> to use __gnu_printf__.
> 
> This works because all basic printf functions support both
> kinds of format strings.
> 
> This fixes a compiler warning:
> 
> qapi/string-output-visitor.c: In function ‘print_type_int’:
> qapi/string-output-visitor.c:34:5: warning: unknown conversion type character ‘l’ in format [-Wformat]
> qapi/string-output-visitor.c:34:5: warning: too many arguments for format [-Wformat-extra-args]
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  compiler.h |    5 +++++
>  1 file changed, 5 insertions(+)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan