From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55207)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1TG5tD-0007RU-Fl
	for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:27:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1TG5tC-00020B-8a
	for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:27:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14860)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1TG5tB-0001yP-TW
	for qemu-devel@nongnu.org; Mon, 24 Sep 2012 06:27:46 -0400
Date: Mon, 24 Sep 2012 11:27:38 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
Message-ID: <20120924102738.GT24071@rhmail.home.annexia.org>
References: <20120924091008.GJ18470@in.ibm.com>
	<20120924091202.GL18470@in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120924091202.GL18470@in.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Anand Avati <aavati@redhat.com>, Vijay Bellur <vbellur@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Harsh Bora <harsh@linux.vnet.ibm.com>, Amar Tumballi <amarts@redhat.com>, qemu-devel@nongnu.org, Daniel Veillard <veillard@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>


On Mon, Sep 24, 2012 at 02:42:02PM +0530, Bharata B Rao wrote:
> qemu: URI parsing library
> 
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Add a new URI parsing library to QEMU. The code has been borrowed from
> libxml2 and libvirt.

Rather than duplicating the libxml2 code, I think it would be better
to depend on libxml2.  While it's not ideal to add more external
dependencies, libxml2 is very commonly available.  Also libxml2 gets
frequent security updates and you never know when the URI code here
might be found to contain some sort of bug / security issue.

This will need a change to the qemu configure script of course.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/