From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36509)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <minchan@kernel.org>) id 1TGPcf-0001Io-Hb
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 03:32:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <minchan@kernel.org>) id 1TGPcZ-00064u-Na
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 03:32:01 -0400
Received: from lgemrelse6q.lge.com ([156.147.1.121]:56812)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <minchan@kernel.org>) id 1TGPcZ-00064g-DB
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 03:31:55 -0400
Date: Tue, 25 Sep 2012 16:34:57 +0900
From: Minchan Kim <minchan@kernel.org>
Message-ID: <20120925073456.GL13234@bbox>
References: <1348224383-1499-1-git-send-email-mgorman@suse.de>
	<1348224383-1499-5-git-send-email-mgorman@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1348224383-1499-5-git-send-email-mgorman@suse.de>
Subject: Re: [Qemu-devel] [PATCH 4/9] mm: compaction: Abort compaction loop
 if lock is contended or run too long
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mel Gorman <mgorman@suse.de>
Cc: Richard Davies <richard@arachsys.com>, KVM <kvm@vger.kernel.org>, QEMU-devel <qemu-devel@nongnu.org>, LKML <linux-kernel@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>, Avi Kivity <avi@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, Shaohua Li <shli@kernel.org>

On Fri, Sep 21, 2012 at 11:46:18AM +0100, Mel Gorman wrote:
> From: Shaohua Li <shli@fusionio.com>
> 
> Changelog since V2
> o Fix BUG_ON triggered due to pages left on cc.migratepages
> o Make compact_zone_order() require non-NULL arg `contended'
> 
> Changelog since V1
> o only abort the compaction if lock is contended or run too long
> o Rearranged the code by Andrea Arcangeli.
> 
> isolate_migratepages_range() might isolate no pages if for example when
> zone->lru_lock is contended and running asynchronous compaction. In this
> case, we should abort compaction, otherwise, compact_zone will run a
> useless loop and make zone->lru_lock is even contended.
> 
> [minchan@kernel.org: Putback pages isolated for migration if aborting]
> [akpm@linux-foundation.org: compact_zone_order requires non-NULL arg contended]
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Shaohua Li <shli@fusionio.com>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Minchan Kim <minchan@kernel.org>

-- 
Kind regards,
Minchan Kim