From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TGds7-0002Ew-OU
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 18:44:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TGds6-0002rH-K4
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 18:44:55 -0400
Received: from hall.aurel32.net ([88.191.126.93]:33791)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TGds6-0002r8-Bs
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 18:44:54 -0400
Date: Wed, 26 Sep 2012 00:44:51 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20120925224451.GC23819@ohm.aurel32.net>
References: <1348523753-25083-1-git-send-email-rth@twiddle.net>
	<1348523753-25083-4-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1348523753-25083-4-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 3/7] target-s390x: Call
 tcg_gen_debug_insn_start
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Mon, Sep 24, 2012 at 02:55:49PM -0700, Richard Henderson wrote:
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-s390x/translate.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/target-s390x/translate.c b/target-s390x/translate.c
> index 3214783..6fa76a0 100644
> --- a/target-s390x/translate.c
> +++ b/target-s390x/translate.c
> @@ -5173,10 +5173,11 @@ static inline void gen_intermediate_code_internal(CPUS390XState *env,
>          if (num_insns + 1 == max_insns && (tb->cflags & CF_LAST_IO)) {
>              gen_io_start();
>          }
> -#if defined(S390X_DEBUG_DISAS_VERBOSE)
> -        LOG_DISAS("pc " TARGET_FMT_lx "\n",
> -                  dc.pc);
> -#endif
> +
> +        if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP | CPU_LOG_TB_OP_OPT))) {
> +            tcg_gen_debug_insn_start(dc.pc);
> +        }
> +
>          disas_s390_insn(env, &dc);
>  
>          num_insns++;
> -- 
> 1.7.11.4
> 
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net