From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50449)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TGrkJ-0005V4-12
	for qemu-devel@nongnu.org; Wed, 26 Sep 2012 09:33:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TGrkA-0001OE-8H
	for qemu-devel@nongnu.org; Wed, 26 Sep 2012 09:33:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23915)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1TGrk9-0001O4-VY
	for qemu-devel@nongnu.org; Wed, 26 Sep 2012 09:33:38 -0400
Date: Wed, 26 Sep 2012 15:33:32 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20120926153332.726f32ea@nial.usersys.redhat.com>
In-Reply-To: <1346961939-32338-1-git-send-email-ehabkost@redhat.com>
References: <1346961939-32338-1-git-send-email-ehabkost@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/5] i386: cpu: remove duplicate feature
 names
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Thu,  6 Sep 2012 17:05:34 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> The problem:
> 
>  - Some features are report at the same time on both CPUID[1].EDX and
>    CPUID[8000_0001].EDX on AMD CPUs (e.g. fpu, tsc, msr, pae, mmx).
>  - "-cpu <model>,+feature" should enable the bit only on CPUID[1] if
>    it's not an AMD CPU, but it should enable the bit on both CPUID[1] and
>    CPUID[8000_0001] if it's an AMD CPU.
>  - The same should happen when implementing CPU properties: setting the
>    property that enables a feature should set the duplicate
> CPUID[8000_0001].EDX bit only if CPU vendor is AMD.
> 
> Reference: http://article.gmane.org/gmane.comp.emulators.qemu/166024
> 
> The solution implemented by this series is:
>  - On the CPU model table and while parsing CPU options/properties, set the
> bit only on CPUID[1] (the x86_def_t.features field).
>  - When finishing initialization of the CPU cpuid fields, duplicate those
>    feature bits on cpuid_ext2_features if and only if the CPU vendor is AMD.
> 
> This series depends on the "x86 CPU patches that didn't get into 1.2"
> series: http://article.gmane.org/gmane.comp.emulators.qemu/168633
>   Message-Id: <1346877673-9136-1-git-send-email-ehabkost@redhat.com>
> 
> 
> Eduardo Habkost (5):
>   i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved
>   i386: kvm: use a #define for the set of alias feature bits
>   i386: cpu: replace EXT2_FEATURE_MASK with CPUID_EXT2_AMD_ALIASES
>   i386: cpu: eliminate duplicate feature names
>   i386: -cpu help: remove reference to specific CPUID leaves/registers
> 
>  target-i386/cpu.c | 59
> +++++++++++++++++++++++++++++++++++-------------------- target-i386/cpu.h |
> 12 +++++++++++ target-i386/kvm.c |  2 +-
>  3 files changed, 51 insertions(+), 22 deletions(-)
> 

Reviewed-by: Igor Mammedov <imammedo@redhat.com>