From: Luiz Capitulino <lcapitulino@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: akong@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org,
Anthony Liguori <anthony@codemonkey.ws>,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex
Date: Thu, 27 Sep 2012 09:14:18 -0300 [thread overview]
Message-ID: <20120927091418.56430a8f@doriath.home> (raw)
In-Reply-To: <50641A3E.3000605@redhat.com>
On Thu, 27 Sep 2012 11:19:58 +0200
Avi Kivity <avi@redhat.com> wrote:
> On 09/26/2012 10:25 PM, Luiz Capitulino wrote:
> > o v3
> >
> > - doc & log fixups
> > - rename KeyCode.hex to KeyCode.number
> >
> > This actually fixes a regression introduced by the qapi conversion,
> > please refer to patch 2/3 for details.
> >
> > It's also important to note that this series changes the QMP
> > interface for the send-key command, but this shouldn't be a problem
> > as we're still in development phase.
> >
>
> Anthony, this regression breaks autotest, so please give this series
> higher priority if possible.
As my other in-flight series have already been reviewed, I'll send a pull
request today with all queued qmp patches I have.
next prev parent reply other threads:[~2012-09-27 12:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 20:25 [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex Luiz Capitulino
2012-09-26 20:25 ` [Qemu-devel] [PATCH 1/3] input: qmp_send_key(): simplify Luiz Capitulino
2012-09-27 9:50 ` Markus Armbruster
2012-09-26 20:25 ` [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex Luiz Capitulino
2012-09-27 11:42 ` Markus Armbruster
2012-09-27 12:57 ` Luiz Capitulino
2012-09-26 20:25 ` [Qemu-devel] [PATCH 3/3] input: index_from_key(): drop unused code Luiz Capitulino
2012-09-26 21:23 ` [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex Eric Blake
2012-09-27 9:19 ` Avi Kivity
2012-09-27 12:14 ` Luiz Capitulino [this message]
2012-09-27 11:43 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927091418.56430a8f@doriath.home \
--to=lcapitulino@redhat.com \
--cc=akong@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).