From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THCyC-0000Ew-O0 for qemu-devel@nongnu.org; Thu, 27 Sep 2012 08:13:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THCy8-0001qZ-RQ for qemu-devel@nongnu.org; Thu, 27 Sep 2012 08:13:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THCy8-0001qU-Iy for qemu-devel@nongnu.org; Thu, 27 Sep 2012 08:13:28 -0400 Date: Thu, 27 Sep 2012 09:14:18 -0300 From: Luiz Capitulino Message-ID: <20120927091418.56430a8f@doriath.home> In-Reply-To: <50641A3E.3000605@redhat.com> References: <1348691138-12879-1-git-send-email-lcapitulino@redhat.com> <50641A3E.3000605@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: akong@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , armbru@redhat.com On Thu, 27 Sep 2012 11:19:58 +0200 Avi Kivity wrote: > On 09/26/2012 10:25 PM, Luiz Capitulino wrote: > > o v3 > > > > - doc & log fixups > > - rename KeyCode.hex to KeyCode.number > > > > This actually fixes a regression introduced by the qapi conversion, > > please refer to patch 2/3 for details. > > > > It's also important to note that this series changes the QMP > > interface for the send-key command, but this shouldn't be a problem > > as we're still in development phase. > > > > Anthony, this regression breaks autotest, so please give this series > higher priority if possible. As my other in-flight series have already been reviewed, I'll send a pull request today with all queued qmp patches I have.