From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48225)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1THFCm-0001jQ-RP
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 10:36:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1THFCe-0003U8-QR
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 10:36:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27975)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1THFCe-0003Ty-HB
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 10:36:36 -0400
Date: Thu, 27 Sep 2012 15:36:23 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20120927143623.GC27933@redhat.com>
References: <20120927135553.GD18285@in.ibm.com>
	<20120927135843.GG18285@in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20120927135843.GG18285@in.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v10 3/5] qemu: URI parsing library
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Anand Avati <aavati@redhat.com>, Vijay Bellur <vbellur@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Harsh Bora <harsh@linux.vnet.ibm.com>, Amar Tumballi <amarts@redhat.com>, qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Daniel Veillard <veillard@redhat.com>

On Thu, Sep 27, 2012 at 07:28:43PM +0530, Bharata B Rao wrote:
> qemu: URI parsing library
> 
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Add a new URI parsing library to QEMU. The code has been borrowed from
> libxml2 and libvirt.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> ---
> 
>  Makefile.objs |    2 
>  uri.c         | 2249 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  uri.h         |  113 +++

IMHO, you should also be importing the URI code test suite from libvirt
to verify that the way you merged/changed the codebases did not break
anything.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|