From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34359)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1THKGG-0001S1-L9
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 16:00:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1THKG7-0007RL-VN
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 16:00:39 -0400
Received: from hall.aurel32.net ([88.191.126.93]:47738)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1THKG7-0007NQ-OX
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 16:00:31 -0400
Date: Thu, 27 Sep 2012 22:00:20 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20120927200020.GH20151@ohm.aurel32.net>
References: <1348766113-18373-1-git-send-email-aurelien@aurel32.net>
	<1348766113-18373-3-git-send-email-aurelien@aurel32.net>
	<506499E2.5080708@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <506499E2.5080708@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 02/13] tcg: add tcg_reg_sync()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Thu, Sep 27, 2012 at 11:24:34AM -0700, Richard Henderson wrote:
> On 09/27/2012 10:15 AM, Aurelien Jarno wrote:
> > Add a new function tcg_reg_sync() to synchronize the canonical location
> > of a temp with the value in the associated register, but without freeing
> > it. Rewrite tcg_reg_free() to first call tcg_reg_sync() and then to free
> > the register.
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> 
> > +/* sync register 'reg' by saving it to the corresponding temporary */
> > +static inline void tcg_reg_sync(TCGContext *s, int reg)
> 
> Isn't the compiler good enough at deciding inlining?
> 

Surprisingly the compiler doesn't inline that many things. For example
all the tcg_reg_alloc_* functions are used only once, but are not
inlined.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net