From: Aurelien Jarno <aurelien@aurel32.net>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 10/13] tcg: don't explicitely save globals and temps
Date: Thu, 27 Sep 2012 22:23:33 +0200 [thread overview]
Message-ID: <20120927202333.GL20151@ohm.aurel32.net> (raw)
In-Reply-To: <5064A555.4080501@twiddle.net>
On Thu, Sep 27, 2012 at 12:13:25PM -0700, Richard Henderson wrote:
> On 09/27/2012 10:15 AM, Aurelien Jarno wrote:
> > @@ -1706,11 +1718,9 @@ static void tcg_reg_alloc_mov(TCGContext *s, const TCGOpDef *def,
> > if (!ots->mem_allocated) {
> > temp_allocate_frame(s, args[0]);
> > }
> > - if (ts->val_type == TEMP_VAL_REG) {
> > - tcg_out_st(s, ots->type, ts->reg, ots->mem_reg, ots->mem_offset);
> > - if (IS_DEAD_ARG(1)) {
> > - temp_dead(s, args[1]);
> > - }
> > + tcg_out_st(s, ots->type, ts->reg, ots->mem_reg, ots->mem_offset);
> > + if (IS_DEAD_ARG(1)) {
> > + temp_dead(s, args[1]);
> > }
> > temp_dead(s, args[0]);
> > } else if (ts->val_type == TEMP_VAL_CONST) {
>
> Did this hunk belong to a different patch? It seems like it belongs
> with the tcg_reg_alloc_mov rewrite.
Yes, it was a simplification meant to go in the patch 7, but it ended up
at the wrong place (the assert above already ensure that ts->val_type ==
TEMP_VAL_REG.
I'll move it to the write patch.
> If it actually depends on patches 7-8, then perhaps a reorder is better.
>
>
> r~
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-09-27 20:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 17:15 [Qemu-devel] [PATCH 00/13] tcg: rework liveness analysis and register allocator Aurelien Jarno
2012-09-27 17:15 ` [Qemu-devel] [PATCH 01/13] tcg: add temp_dead() Aurelien Jarno
2012-09-27 18:19 ` Richard Henderson
2012-09-27 17:15 ` [Qemu-devel] [PATCH 02/13] tcg: add tcg_reg_sync() Aurelien Jarno
2012-09-27 18:24 ` Richard Henderson
2012-09-27 20:00 ` Aurelien Jarno
2012-09-27 17:15 ` [Qemu-devel] [PATCH 03/13] tcg: add temp_sync() Aurelien Jarno
2012-09-27 18:30 ` Richard Henderson
2012-09-27 20:02 ` Aurelien Jarno
2012-09-27 17:15 ` [Qemu-devel] [PATCH 04/13] tcg: sync output arguments on liveness request Aurelien Jarno
2012-09-27 18:39 ` Richard Henderson
2012-09-27 20:05 ` Aurelien Jarno
2012-09-27 20:10 ` Richard Henderson
2012-09-27 20:25 ` Aurelien Jarno
2012-09-27 17:15 ` [Qemu-devel] [PATCH 05/13] tcg: rework liveness analysis Aurelien Jarno
2012-09-27 18:54 ` Richard Henderson
2012-09-27 17:15 ` [Qemu-devel] [PATCH 06/13] tcg: improve tcg_reg_alloc_movi() Aurelien Jarno
2012-09-27 18:55 ` Richard Henderson
2012-09-27 17:15 ` [Qemu-devel] [PATCH 07/13] tcg: rewrite tcg_reg_alloc_mov() Aurelien Jarno
2012-09-27 19:09 ` Richard Henderson
2012-09-27 20:17 ` Aurelien Jarno
2012-09-27 22:18 ` Richard Henderson
2012-09-27 17:15 ` [Qemu-devel] [PATCH 08/13] tcg: always mark dead input arguments as dead Aurelien Jarno
2012-09-27 19:10 ` Richard Henderson
2012-09-27 17:15 ` [Qemu-devel] [PATCH 09/13] tcg: start with local temps in TEMP_VAL_MEM state Aurelien Jarno
2012-09-27 19:10 ` Richard Henderson
2012-09-27 17:15 ` [Qemu-devel] [PATCH 10/13] tcg: don't explicitely save globals and temps Aurelien Jarno
2012-09-27 19:13 ` Richard Henderson
2012-09-27 20:23 ` Aurelien Jarno [this message]
2012-09-27 17:15 ` [Qemu-devel] [PATCH 11/13] tcg: sync globals for pure helpers instead of saving them Aurelien Jarno
2012-09-27 19:39 ` Richard Henderson
2012-09-27 20:34 ` Aurelien Jarno
2012-09-27 22:02 ` Richard Henderson
2012-09-27 17:15 ` [Qemu-devel] [PATCH 12/13] tcg: fix some op flags Aurelien Jarno
2012-09-27 19:44 ` Richard Henderson
2012-09-27 17:15 ` [Qemu-devel] [PATCH 13/13] tcg: rework TCG ops flags Aurelien Jarno
2012-09-27 19:56 ` Richard Henderson
2012-09-27 20:37 ` Aurelien Jarno
2012-09-27 22:00 ` Richard Henderson
2012-09-27 23:08 ` Aurelien Jarno
2012-09-27 23:11 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927202333.GL20151@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).