From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39888)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1THW71-000583-C9
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 04:39:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1THW6v-0006Io-1r
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 04:39:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18993)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1THW6u-0006IX-PD
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 04:39:48 -0400
Date: Fri, 28 Sep 2012 09:39:37 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20120928083937.GG6087@redhat.com>
References: <20120927135553.GD18285@in.ibm.com>
	<20120927135843.GG18285@in.ibm.com>
	<20120927143623.GC27933@redhat.com> <506476E3.9030200@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <506476E3.9030200@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v10 3/5] qemu: URI parsing library
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Anand Avati <aavati@redhat.com>, Vijay Bellur <vbellur@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Harsh Bora <harsh@linux.vnet.ibm.com>, Amar Tumballi <amarts@redhat.com>, qemu-devel@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, Bharata B Rao <bharata@linux.vnet.ibm.com>, Daniel Veillard <veillard@redhat.com>

On Thu, Sep 27, 2012 at 05:55:15PM +0200, Paolo Bonzini wrote:
> Il 27/09/2012 16:36, Daniel P. Berrange ha scritto:
> >> > qemu: URI parsing library
> >> > 
> >> > From: Paolo Bonzini <pbonzini@redhat.com>
> >> > 
> >> > Add a new URI parsing library to QEMU. The code has been borrowed from
> >> > libxml2 and libvirt.
> >> > 
> >> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> >> > ---
> >> > 
> >> >  Makefile.objs |    2 
> >> >  uri.c         | 2249 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >> >  uri.h         |  113 +++
> > IMHO, you should also be importing the URI code test suite from libvirt
> > to verify that the way you merged/changed the codebases did not break
> > anything.
> 
> Yes, can be done separately though.

In this case I disagree.  The URI parsing code here is complex enough that
I don't think any reviewer can credibly claim to spot flaws that might
have been introduced when combing the libvirt + libxml2 URI code parts.
A test suite is the only way to validate this kind of complex code IMHO
and so should be included in this patch.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|