qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>,
	Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH RESEND 0/3] Introduce virtqueue_get_avail_bytes()
Date: Fri, 28 Sep 2012 12:00:12 +0200	[thread overview]
Message-ID: <20120928100012.GA7294@redhat.com> (raw)
In-Reply-To: <cover.1348511596.git.amit.shah@redhat.com>

On Tue, Sep 25, 2012 at 12:05:13AM +0530, Amit Shah wrote:
> This is a rebased version of the patchset sent earlier.
> 
> The current virtqueue_avail_bytes() is a weird API: it's oddly-named:
> doesn't tell us what the API is going to do, and also suits just one
> use-case (that in virtio-net.c).
> 
> Introduce virtqueue_get_avail_bytes(), which returns the number of
> bytes in the vq available for input as well as output.
> virtqueue_avail_bytes() is made a wrapper around this new function for
> now.  It should be deprecated soon, though.
> 
> Doing this will also help with the virtio-rng patch where a
> VirtQueueElement is popped only to find out what its size is.  With
> this series applied, the popping (and the subsequent save/load of
> state for migration) isn't necessary.
> 
> The virtio-serial-bus code becomes better too, that's patch 3 here.
> 
> Please apply,

Applied, thanks.

> Amit Shah (3):
>   virtio: use unsigned int for counting bytes in vq
>   virtio: Introduce virtqueue_get_avail_bytes()
>   virtio-serial-bus: let chardev know the exact number of bytes
>     requested
> 
>  hw/virtio-serial-bus.c |   11 +++--------
>  hw/virtio.c            |   30 ++++++++++++++++++++++--------
>  hw/virtio.h            |    5 ++++-
>  3 files changed, 29 insertions(+), 17 deletions(-)
> 
> -- 
> 1.7.7.6

      parent reply	other threads:[~2012-09-28  9:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24 18:35 [Qemu-devel] [PATCH RESEND 0/3] Introduce virtqueue_get_avail_bytes() Amit Shah
2012-09-24 18:35 ` [Qemu-devel] [PATCH RESEND 1/3] virtio: use unsigned int for counting bytes in vq Amit Shah
2012-09-24 18:35 ` [Qemu-devel] [PATCH RESEND 2/3] virtio: Introduce virtqueue_get_avail_bytes() Amit Shah
2012-09-24 18:35 ` [Qemu-devel] [PATCH RESEND 3/3] virtio-serial-bus: let chardev know the exact number of bytes requested Amit Shah
2012-09-28 10:00 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120928100012.GA7294@redhat.com \
    --to=mst@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).