From: Igor Mammedov <imammedo@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: stefanha@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] trivial fix of inet_listen() parameter
Date: Sat, 29 Sep 2012 22:57:18 +0200 [thread overview]
Message-ID: <20120929225718.15726033@thinkpad.mammed.net> (raw)
In-Reply-To: <1348911151-7744-1-git-send-email-akong@redhat.com>
On Sat, 29 Sep 2012 17:32:31 +0800
Amos Kong <akong@redhat.com> wrote:
> .. int inet_listen(const char *str, char *ostr, int olen,
> .. int socktype, int port_offset, Error **errp)
>
> Here 'ostr' is NULL, so change 'olen' to zero.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> migration-tcp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/migration-tcp.c b/migration-tcp.c
> index a15c2b8..34d6d89 100644
> --- a/migration-tcp.c
> +++ b/migration-tcp.c
> @@ -123,7 +123,7 @@ int tcp_start_incoming_migration(const char *host_port, Error **errp)
> {
> int s;
>
> - s = inet_listen(host_port, NULL, 256, SOCK_STREAM, 0, errp);
> + s = inet_listen(host_port, NULL, 0, SOCK_STREAM, 0, errp);
>
> if (s < 0) {
> return -1;
> --
> 1.7.1
>
Reviewed-By: Igor Mammedov <imammedo@redhat.com>
--
Regards,
Igor
prev parent reply other threads:[~2012-09-29 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 9:32 [Qemu-devel] [PATCH] trivial fix of inet_listen() parameter Amos Kong
2012-09-29 20:57 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120929225718.15726033@thinkpad.mammed.net \
--to=imammedo@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).