From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TI46L-0001ix-2O for qemu-devel@nongnu.org; Sat, 29 Sep 2012 16:57:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TI46K-0002Nm-7J for qemu-devel@nongnu.org; Sat, 29 Sep 2012 16:57:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TI46J-0002NX-V8 for qemu-devel@nongnu.org; Sat, 29 Sep 2012 16:57:28 -0400 Date: Sat, 29 Sep 2012 22:57:18 +0200 From: Igor Mammedov Message-ID: <20120929225718.15726033@thinkpad.mammed.net> In-Reply-To: <1348911151-7744-1-git-send-email-akong@redhat.com> References: <1348911151-7744-1-git-send-email-akong@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] trivial fix of inet_listen() parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: stefanha@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Sat, 29 Sep 2012 17:32:31 +0800 Amos Kong wrote: > .. int inet_listen(const char *str, char *ostr, int olen, > .. int socktype, int port_offset, Error **errp) > > Here 'ostr' is NULL, so change 'olen' to zero. > > Signed-off-by: Amos Kong > --- > migration-tcp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/migration-tcp.c b/migration-tcp.c > index a15c2b8..34d6d89 100644 > --- a/migration-tcp.c > +++ b/migration-tcp.c > @@ -123,7 +123,7 @@ int tcp_start_incoming_migration(const char *host_port, Error **errp) > { > int s; > > - s = inet_listen(host_port, NULL, 256, SOCK_STREAM, 0, errp); > + s = inet_listen(host_port, NULL, 0, SOCK_STREAM, 0, errp); > > if (s < 0) { > return -1; > -- > 1.7.1 > Reviewed-By: Igor Mammedov -- Regards, Igor