Re: [Qemu-devel] [PATCH v2 0/9] Embedded NBD server

[Luiz Capitulino <lcapitulino@redhat.com>]

On Mon,  1 Oct 2012 16:52:15 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> This series rebases the previous qemu-sockets patches for error
> propagation and uses the new QAPI-friendly socket functions in the
> embedded NBD server.  The changes are due to Orit's patches being
> now in, some early parts being in Luiz's queue, and glusterfs
> patches not having touched qemu-sockets.c in the end.
> 
> Patches 1 to 4 start moving qemu-sockets functions away from error_report
> (or printf) and away from QemuOpts.  Patch 5 makes it easier to reuse
> the address parser of inet_parse in the new socket_parse function.
> Patch 6 introduces QAPI-friendly socket parsing and creation functions.
> 
> Patches 7 and 8 introduces the QMP commands, and patch 9 introduces the
> HMP version.

Some comments against 4/9, plus this:

  CC    qemu-sockets.o
/home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c: In function ‘socket_connect’:
/home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c:894:9: error: passing argument 2 of ‘inet_connect_opts’ makes pointer from integer without a cast [-Werror]
/home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c:365:5: note: expected ‘struct Error **’ but argument is of type ‘int’
/home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c:894:9: error: too many arguments to function ‘inet_connect_opts’
/home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c:365:5: note: declared here
cc1: all warnings being treated as errors
make: *** [qemu-sockets.o] Error 1
make: *** Waiting for unfinished jobs....

It's also worth it to mention that this series actually depends on my
last pull request, but it's ok if this is going through my tree.

Otherwise, looks good.

> 
> Paolo
> 
> Paolo Bonzini (9):
>   build: add QAPI files to the tools
>   qapi: add socket address types
>   qemu-sockets: add error propagation to inet_parse
>   qemu-sockets: add error propagation to Unix socket functions
>   qemu-sockets: return IPSocketAddress from inet_parse
>   qemu-sockets: add socket_listen, socket_connect, socket_parse
>   block: add close notifiers
>   qmp: add NBD server commands
>   hmp: add NBD server commands
> 
>  Makefile.objs       |   8 +-
>  block.c             |  19 +++-
>  block.h             |   1 +
>  block_int.h         |   2 +
>  blockdev-nbd.c      | 119 ++++++++++++++++++++++++
>  hmp-commands.hx     |  29 ++++++
>  hmp.c               |  55 +++++++++++
>  hmp.h               |   2 +
>  nbd.c               |   4 +-
>  qapi-schema.json    |  96 +++++++++++++++++++
>  qemu-char.c         |   4 +-
>  qemu-sockets.c      | 261 +++++++++++++++++++++++++++++++++++++++-------------
>  qemu-tool.c         |   6 ++
>  qemu_socket.h       |  12 ++-
>  qga/channel-posix.c |   2 +-
>  qmp-commands.hx     |  16 ++++
>  ui/vnc.c            |   4 +-
>  17 file modificati, 557 inserzioni(+), 83 rimozioni(-)
>  create mode 100644 blockdev-nbd.c
>