From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIkOb-0001nt-N9 for qemu-devel@nongnu.org; Mon, 01 Oct 2012 14:07:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIkOZ-0006oi-6j for qemu-devel@nongnu.org; Mon, 01 Oct 2012 14:07:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIkOY-0006nv-VG for qemu-devel@nongnu.org; Mon, 01 Oct 2012 14:07:07 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q91I76nf009987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Oct 2012 14:07:06 -0400 Date: Mon, 1 Oct 2012 15:08:00 -0300 From: Luiz Capitulino Message-ID: <20121001150800.443c2bb4@doriath.home> In-Reply-To: <1349103144-6827-1-git-send-email-pbonzini@redhat.com> References: <1349103144-6827-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/9] Embedded NBD server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Mon, 1 Oct 2012 16:52:15 +0200 Paolo Bonzini wrote: > This series rebases the previous qemu-sockets patches for error > propagation and uses the new QAPI-friendly socket functions in the > embedded NBD server. The changes are due to Orit's patches being > now in, some early parts being in Luiz's queue, and glusterfs > patches not having touched qemu-sockets.c in the end. >=20 > Patches 1 to 4 start moving qemu-sockets functions away from error_report > (or printf) and away from QemuOpts. Patch 5 makes it easier to reuse > the address parser of inet_parse in the new socket_parse function. > Patch 6 introduces QAPI-friendly socket parsing and creation functions. >=20 > Patches 7 and 8 introduces the QMP commands, and patch 9 introduces the > HMP version. Some comments against 4/9, plus this: CC qemu-sockets.o /home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c: In function =E2=80= =98socket_connect=E2=80=99: /home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c:894:9: error: passin= g argument 2 of =E2=80=98inet_connect_opts=E2=80=99 makes pointer from inte= ger without a cast [-Werror] /home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c:365:5: note: expecte= d =E2=80=98struct Error **=E2=80=99 but argument is of type =E2=80=98int=E2= =80=99 /home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c:894:9: error: too ma= ny arguments to function =E2=80=98inet_connect_opts=E2=80=99 /home/lcapitulino/work/src/qmp-unstable/qemu-sockets.c:365:5: note: declare= d here cc1: all warnings being treated as errors make: *** [qemu-sockets.o] Error 1 make: *** Waiting for unfinished jobs.... It's also worth it to mention that this series actually depends on my last pull request, but it's ok if this is going through my tree. Otherwise, looks good. >=20 > Paolo >=20 > Paolo Bonzini (9): > build: add QAPI files to the tools > qapi: add socket address types > qemu-sockets: add error propagation to inet_parse > qemu-sockets: add error propagation to Unix socket functions > qemu-sockets: return IPSocketAddress from inet_parse > qemu-sockets: add socket_listen, socket_connect, socket_parse > block: add close notifiers > qmp: add NBD server commands > hmp: add NBD server commands >=20 > Makefile.objs | 8 +- > block.c | 19 +++- > block.h | 1 + > block_int.h | 2 + > blockdev-nbd.c | 119 ++++++++++++++++++++++++ > hmp-commands.hx | 29 ++++++ > hmp.c | 55 +++++++++++ > hmp.h | 2 + > nbd.c | 4 +- > qapi-schema.json | 96 +++++++++++++++++++ > qemu-char.c | 4 +- > qemu-sockets.c | 261 +++++++++++++++++++++++++++++++++++++++-------= ------ > qemu-tool.c | 6 ++ > qemu_socket.h | 12 ++- > qga/channel-posix.c | 2 +- > qmp-commands.hx | 16 ++++ > ui/vnc.c | 4 +- > 17 file modificati, 557 inserzioni(+), 83 rimozioni(-) > create mode 100644 blockdev-nbd.c >=20