From: Aurelien Jarno <aurelien@aurel32.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>,
Richard Henderson <rth@twiddle.net>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] fpu/softfloat.c: Return correctly signed values from uint64_to_float32
Date: Mon, 1 Oct 2012 18:59:10 +0200 [thread overview]
Message-ID: <20121001165910.GC4055@ohm.aurel32.net> (raw)
In-Reply-To: <CAFEAcA-N08iVD3e1hN6-W7d_m8b_yNMQY9U2auJV7Jspwif1bg@mail.gmail.com>
On Fri, Sep 28, 2012 at 04:42:16PM +0100, Peter Maydell wrote:
> On 28 September 2012 16:17, Peter Maydell <peter.maydell@linaro.org> wrote:
> > The uint64_to_float32() conversion function was incorrectly always
> > returning numbers with the sign bit set (ie negative numbers). Correct
> > this so we return positive numbers instead.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > As far as I can see we use this function only in the three PPC SPE
> > insns efscfuf, efsctsf, efsctuf. It is therefore untested(!); if
> > anybody with PPC hw to test against could check the results of
> > those functions that would be cool.
SPE instructions are not common on the non-embedded world, as far as I
know it should be tested using the e500 CPU. That said I don't have a
kernel nor an image for such a machine.
> ...incidentally in two of those uses we're operating on a constant:
> tmp = uint64_to_float64(1ULL << 32, &env->vec_status);
> and it would probably be better to use make_float64() instead.
>
Agreed.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-10-01 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 15:17 [Qemu-devel] [PATCH] fpu/softfloat.c: Return correctly signed values from uint64_to_float32 Peter Maydell
2012-09-28 15:42 ` Peter Maydell
2012-10-01 16:59 ` Aurelien Jarno [this message]
2012-10-01 16:56 ` Aurelien Jarno
2012-10-01 20:12 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001165910.GC4055@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=agraf@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).