From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56419)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TIp28-0006L5-Do
	for qemu-devel@nongnu.org; Mon, 01 Oct 2012 19:04:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TIp27-00022s-Hc
	for qemu-devel@nongnu.org; Mon, 01 Oct 2012 19:04:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TIp27-00022m-8R
	for qemu-devel@nongnu.org; Mon, 01 Oct 2012 19:04:15 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q91N4DB0008232
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 1 Oct 2012 19:04:13 -0400
Date: Mon, 1 Oct 2012 20:05:07 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121001200507.62da4412@doriath.home>
In-Reply-To: <5069EA08.8050500@redhat.com>
References: <1349103144-6827-1-git-send-email-pbonzini@redhat.com>
	<1349103144-6827-5-git-send-email-pbonzini@redhat.com>
	<20121001141721.5ae57b52@doriath.home>
	<5069EA08.8050500@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 4/9] qemu-sockets: add error propagation
 to Unix socket functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 01 Oct 2012 21:07:52 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 01/10/2012 19:17, Luiz Capitulino ha scritto:
> >> >      if (bind(sock, (struct sockaddr*) &un, sizeof(un)) < 0) {
> >> > -        fprintf(stderr, "bind(unix:%s): %s\n", un.sun_path, strerror(errno));
> >> > +        error_set(errp, QERR_SOCKET_BIND_FAILED);
> > This drops error information, making the error message worse. I believe
> > you have a reason to not use error_setg()?
> 
> I was waiting for the end of the discussion on errno to add
> error_setg_errno.

The decision was to not add errno now, right?

> > Also, I see that in some hunks you do something like:
> > 
> >   -            fd = unix_listen_opts(opts);
> >   +            fd = unix_listen_opts(opts, NULL);
> > 
> > This will break printing the error message to the user. It's fine by me if
> > you do this only temporarily (ie. this is fixed by the next or a later patch),
> > but want to double check that you're aware of it.
> 
> I want to avoid super-large patch series, so I would prefer to fix it
> later in the 1.3 development.

We at least need to have the patches flying, I don't think it's ok to
break error reporting like that.