Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library

[Daniel Veillard <veillard@redhat.com>]

On Thu, Sep 27, 2012 at 11:07:49AM +0200, Paolo Bonzini wrote:
> Il 27/09/2012 11:03, Avi Kivity ha scritto:
> > On 09/24/2012 01:11 PM, Paolo Bonzini wrote:
> > > A better plan would be to incorporate this code into glib, completing
> > > the extremely sparse URI support that is already there.  However, we
> > > would not be able to use it anyway, because we support compiling on old
> > > glib versions.
> >
> > If the same (or very similar) API is retained,
> 
> Yes, there is exactly one change in the API (modulo renaming) so we
> could just use some #defines or wrappers.

  BTW I'm fine by this assuming:
   - someone keeps an eye on libxml2 upstream in case some security
     problem shows up in that part of the code
   - the code used is the 2.9.0 one where I added quite a bit of
     cleanup on memory handling.

> > we could fall back on
> > libxml2 when glib uri parsing is unavailable.
> 
> That's an interesting idea.  The assumption that glib wants URI parsing
> is not proved, but it may work out.

  Well glib coding style and libxml2 one are fairly different, assuming
you get the change into glib, that will be a relatively different code
base (my recollection is that glib exits on allocation error which tend
to impact API design so this may be more complex than just different
naming for the functions).

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/