From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIuaD-0005jV-HV for qemu-devel@nongnu.org; Tue, 02 Oct 2012 00:59:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIuaC-0004p4-EC for qemu-devel@nongnu.org; Tue, 02 Oct 2012 00:59:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIuaC-0004mt-5k for qemu-devel@nongnu.org; Tue, 02 Oct 2012 00:59:48 -0400 Date: Tue, 2 Oct 2012 12:59:11 +0800 From: Daniel Veillard Message-ID: <20121002045911.GJ27767@redhat.com> References: <1475119461.458336.1348485090253.JavaMail.root@redhat.com> <50641661.9080701@redhat.com> <50641765.1030109@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50641765.1030109@redhat.com> Subject: Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library Reply-To: veillard@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Anthony Liguori , Anand Avati , Vijay Bellur , Stefan Hajnoczi , Harsh Bora , Amar Tumballi , qemu-devel@nongnu.org, "Richard W.M. Jones" , Blue Swirl , Avi Kivity , Bharata B Rao On Thu, Sep 27, 2012 at 11:07:49AM +0200, Paolo Bonzini wrote: > Il 27/09/2012 11:03, Avi Kivity ha scritto: > > On 09/24/2012 01:11 PM, Paolo Bonzini wrote: > > > A better plan would be to incorporate this code into glib, completing > > > the extremely sparse URI support that is already there. However, we > > > would not be able to use it anyway, because we support compiling on old > > > glib versions. > > > > If the same (or very similar) API is retained, > > Yes, there is exactly one change in the API (modulo renaming) so we > could just use some #defines or wrappers. BTW I'm fine by this assuming: - someone keeps an eye on libxml2 upstream in case some security problem shows up in that part of the code - the code used is the 2.9.0 one where I added quite a bit of cleanup on memory handling. > > we could fall back on > > libxml2 when glib uri parsing is unavailable. > > That's an interesting idea. The assumption that glib wants URI parsing > is not proved, but it may work out. Well glib coding style and libxml2 one are fairly different, assuming you get the change into glib, that will be a relatively different code base (my recollection is that glib exits on allocation error which tend to impact API design so this may be more complex than just different naming for the functions). Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/