From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TJ4NL-0000Lr-L2
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 11:27:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TJ4NF-0003T7-S6
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 11:27:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60919)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TJ4NF-0003Rt-Jb
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 11:27:05 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q92FR4pF012258
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 2 Oct 2012 11:27:04 -0400
Date: Tue, 2 Oct 2012 12:27:58 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121002122758.12074163@doriath.home>
In-Reply-To: <506AF930.7000902@redhat.com>
References: <1349103144-6827-1-git-send-email-pbonzini@redhat.com>
	<1349103144-6827-3-git-send-email-pbonzini@redhat.com>
	<506A2D98.4080300@redhat.com> <506AAD22.5040305@redhat.com>
	<506AD288.7010204@redhat.com>
	<20121002092727.1a1cf31d@doriath.home>
	<506AF930.7000902@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org

On Tue, 02 Oct 2012 16:24:48 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 02/10/2012 14:27, Luiz Capitulino ha scritto:
> >>>> > >> for a port range, all because of the possibility of named ports; should
> >>>> > >> '*to' be a 'str' if only for symmetry in the output?  But it's
> >>>> > >> bike-shedding, so I'll live with whatever works (that is, I'm not
> >>>> > >> requesting a v3 on this patch).
> >>> > > 
> >>> > > Would it be better if I changed 'to' to 'count'?
> >> > 
> >> > That does look a little better:
> >> > 
> >> > 'host':'localhost', 'port':'1000', 'count':2
> >> > 
> >> > for the 2-port range 1000-1001.  But it's all the same information, so
> >> > I'm not strongly tied to any particular representation, as long as
> >> > libvirt can parse it when querying and produce it when starting NBD.
> > Wouldn't it be cleaner to pass a list of port numbers? We could have:
> > 
> >  *port-list: [ 'int' ]
> >  *service: 'str'
> 
> A list of ports doesn't work too well for say 5900-5999.  I think the
> port + count is the simplest.

True, but consider making it a union then, so that we can have service
as a string and port as an integer.