From: Luiz Capitulino <lcapitulino@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir
Date: Wed, 3 Oct 2012 15:53:25 -0300 [thread overview]
Message-ID: <20121003155325.4cc3bce8@doriath.home> (raw)
In-Reply-To: <506C84B5.8030006@redhat.com>
On Wed, 03 Oct 2012 20:32:21 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 03/10/2012 19:24, Luiz Capitulino ha scritto:
> > Defaults to /var/run.
>
> Please add instead --localstatedir (defaulting to ${prefix}/var), and
> make the guest agent's directory /run inside that one. Packagers
> already know to override --localstatedir=/var, in some cases macros even
> do it automatically.
Well, that was my first version but I discarded it for two reasons.
First, --localstatedir is a host-side setting but qemu-ga is not supposed to
run in the host. What if I want a different setting for guests?
Second, having /run appended to --localstatedir (or whatever we choose) may
have a bad effect if qemu is built with --localstatedir=, where qemu-ga's
state will be "/run" (good for Fedora, but might not be good for other
distros or other unixes).
I'm not strong about this though, it just was my reasoning while doing this.
next prev parent reply other threads:[~2012-10-03 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 17:24 [Qemu-devel] [PATCH 0/3] qemu-ga: change default state dir to /var/run Luiz Capitulino
2012-10-03 17:24 ` [Qemu-devel] [PATCH 1/3] configure: guest_agent -> qemuga Luiz Capitulino
2012-10-03 18:08 ` Michael Roth
2012-10-03 17:24 ` [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir Luiz Capitulino
2012-10-03 18:13 ` Michael Roth
2012-10-03 18:23 ` Michael Roth
2012-10-03 18:32 ` Paolo Bonzini
2012-10-03 18:53 ` Luiz Capitulino [this message]
2012-10-03 18:56 ` Paolo Bonzini
2012-10-03 19:00 ` Luiz Capitulino
2012-10-03 17:24 ` [Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR Luiz Capitulino
2012-10-03 18:20 ` Michael Roth
2012-10-03 18:33 ` [Qemu-devel] [PATCH 0/3] qemu-ga: change default state dir to /var/run Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003155325.4cc3bce8@doriath.home \
--to=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).