From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60683)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TJU3e-0005sT-PA
	for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:52:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TJU3d-000656-Oo
	for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:52:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9555)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TJU3d-00064A-Gz
	for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:52:33 -0400
Date: Wed, 3 Oct 2012 15:53:25 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121003155325.4cc3bce8@doriath.home>
In-Reply-To: <506C84B5.8030006@redhat.com>
References: <1349285059-5415-1-git-send-email-lcapitulino@redhat.com>
	<1349285059-5415-3-git-send-email-lcapitulino@redhat.com>
	<506C84B5.8030006@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org

On Wed, 03 Oct 2012 20:32:21 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 03/10/2012 19:24, Luiz Capitulino ha scritto:
> > Defaults to /var/run.
> 
> Please add instead --localstatedir (defaulting to ${prefix}/var), and
> make the guest agent's directory /run inside that one.  Packagers
> already know to override --localstatedir=/var, in some cases macros even
> do it automatically.

Well, that was my first version but I discarded it for two reasons.

First, --localstatedir is a host-side setting but qemu-ga is not supposed to
run in the host. What if I want a different setting for guests?

Second, having /run appended to --localstatedir (or whatever we choose) may
have a bad effect if qemu is built with --localstatedir=, where qemu-ga's
state will be "/run" (good for Fedora, but might not be good for other
distros or other unixes).

I'm not strong about this though, it just was my reasoning while doing this.