From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJUC5-0001Vp-PM for qemu-devel@nongnu.org; Wed, 03 Oct 2012 15:01:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJUC4-0000j4-Fo for qemu-devel@nongnu.org; Wed, 03 Oct 2012 15:01:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJUC4-0000ib-5K for qemu-devel@nongnu.org; Wed, 03 Oct 2012 15:01:16 -0400 Date: Wed, 3 Oct 2012 16:00:58 -0300 From: Luiz Capitulino Message-ID: <20121003160058.1c042f1c@doriath.home> In-Reply-To: <506C8A5F.8060403@redhat.com> References: <1349285059-5415-1-git-send-email-lcapitulino@redhat.com> <1349285059-5415-3-git-send-email-lcapitulino@redhat.com> <506C84B5.8030006@redhat.com> <20121003155325.4cc3bce8@doriath.home> <506C8A5F.8060403@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org On Wed, 03 Oct 2012 20:56:31 +0200 Paolo Bonzini wrote: > Il 03/10/2012 20:53, Luiz Capitulino ha scritto: > > On Wed, 03 Oct 2012 20:32:21 +0200 > > Paolo Bonzini wrote: > > > >> Il 03/10/2012 19:24, Luiz Capitulino ha scritto: > >>> Defaults to /var/run. > >> > >> Please add instead --localstatedir (defaulting to ${prefix}/var), and > >> make the guest agent's directory /run inside that one. Packagers > >> already know to override --localstatedir=/var, in some cases macros even > >> do it automatically. > > > > Well, that was my first version but I discarded it for two reasons. > > > > First, --localstatedir is a host-side setting but qemu-ga is not supposed to > > run in the host. What if I want a different setting for guests? > > Then you should build twice, like you do when the guest is a completely > different OS. Fine with me if this is acceptable. > > Second, having /run appended to --localstatedir (or whatever we choose) may > > have a bad effect if qemu is built with --localstatedir=, where qemu-ga's > > state will be "/run" (good for Fedora, but might not be good for other > > distros or other unixes). > > I'm not sure I follow, it would be --localstatedir=/var usually. Even > Fedora would not use --localstatedir=. Which part you didn't follow, that no one would build with --localstatedir= or what is the problem if this is done? If it's the former, then I buy that argument and will change the series.