From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] configure: guest_agent -> qemuga
Date: Wed, 3 Oct 2012 13:08:34 -0500 [thread overview]
Message-ID: <20121003180834.GA16157@illuin> (raw)
In-Reply-To: <1349285059-5415-2-git-send-email-lcapitulino@redhat.com>
On Wed, Oct 03, 2012 at 02:24:17PM -0300, Luiz Capitulino wrote:
> Next commit will add a new qemu-ga variable in configure, having
> guest_agent as a prefix is too long, let's use qemuga instead.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Acked-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
> configure | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 8f99b7b..4cfcdc6 100755
> --- a/configure
> +++ b/configure
> @@ -214,7 +214,7 @@ smartcard_nss=""
> usb_redir=""
> opengl=""
> zlib="yes"
> -guest_agent="yes"
> +qemuga="yes"
> want_tools="yes"
> libiscsi=""
> coroutine=""
> @@ -844,9 +844,9 @@ for opt do
> ;;
> --disable-zlib-test) zlib="no"
> ;;
> - --enable-guest-agent) guest_agent="yes"
> + --enable-guest-agent) qemuga="yes"
> ;;
> - --disable-guest-agent) guest_agent="no"
> + --disable-guest-agent) qemuga="no"
> ;;
> --enable-tools) want_tools="yes"
> ;;
> @@ -3059,7 +3059,7 @@ if test "$softmmu" = yes ; then
> fi
> fi
> if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then
> - if [ "$guest_agent" = "yes" ]; then
> + if [ "$qemuga" = "yes" ]; then
> tools="qemu-ga\$(EXESUF) $tools"
> fi
> fi
> @@ -3167,7 +3167,7 @@ echo "nss used $smartcard_nss"
> echo "usb net redir $usb_redir"
> echo "OpenGL support $opengl"
> echo "libiscsi support $libiscsi"
> -echo "build guest agent $guest_agent"
> +echo "build guest agent $qemuga"
> echo "seccomp support $seccomp"
> echo "coroutine backend $coroutine_backend"
>
> --
> 1.7.12.315.g682ce8b
>
>
next prev parent reply other threads:[~2012-10-03 18:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 17:24 [Qemu-devel] [PATCH 0/3] qemu-ga: change default state dir to /var/run Luiz Capitulino
2012-10-03 17:24 ` [Qemu-devel] [PATCH 1/3] configure: guest_agent -> qemuga Luiz Capitulino
2012-10-03 18:08 ` Michael Roth [this message]
2012-10-03 17:24 ` [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir Luiz Capitulino
2012-10-03 18:13 ` Michael Roth
2012-10-03 18:23 ` Michael Roth
2012-10-03 18:32 ` Paolo Bonzini
2012-10-03 18:53 ` Luiz Capitulino
2012-10-03 18:56 ` Paolo Bonzini
2012-10-03 19:00 ` Luiz Capitulino
2012-10-03 17:24 ` [Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR Luiz Capitulino
2012-10-03 18:20 ` Michael Roth
2012-10-03 18:33 ` [Qemu-devel] [PATCH 0/3] qemu-ga: change default state dir to /var/run Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003180834.GA16157@illuin \
--to=mdroth@linux.vnet.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).