From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJU5c-0006gT-89 for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:54:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJU5b-0006WY-3f for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:54:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJU5a-0006WN-Rr for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:54:35 -0400 Date: Wed, 3 Oct 2012 15:26:52 -0300 From: Marcelo Tosatti Message-ID: <20121003182652.GA32381@amt.cnet> References: <20121003105255.972669952@amt.cnet> <20121003105509.391284251@amt.cnet> <87fw5vhb5a.fsf@codemonkey.ws> <20121003150341.GA15164@amt.cnet> <506C5DED.7000705@web.de> <878vbn4gs9.fsf@codemonkey.ws> <506C74E0.8080409@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <506C74E0.8080409@web.de> Subject: Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, Gerd Hoffmann On Wed, Oct 03, 2012 at 07:24:48PM +0200, Jan Kiszka wrote: > On 2012-10-03 19:16, Anthony Liguori wrote: > > Jan Kiszka writes: > > > >> On 2012-10-03 17:03, Marcelo Tosatti wrote: > >>> On Wed, Oct 03, 2012 at 09:40:17AM -0500, Anthony Liguori wrote: > >>>> Marcelo Tosatti writes: > >>>> > >>>>> Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from qemu-kvm.git. > >>>>> > >>>>> From: Jan Kiszka > >>>>> > >>>>> Upstream is moving towards this mechanism, so start using it in qemu-kvm > >>>>> already to configure the specific defaults: kvm enabled on, just like > >>>>> in-kernel irqchips. > >>>>> > >>>>> Signed-off-by: Marcelo Tosatti > >>>> > >>>> > >>>> Reviewed-by: Anthony Liguori > >>>> > >>>> Although it's a little odd to have From: Jan without a SoB... > >>> > >>> Agree, Jan can you ACK? > >> > >> I wasn't able to join the call yesterday: Is there a removal schedule > >> associated with those switches? Also, why pushing things upstream, even > >> when only for one release, that have been loudly deprecated for a while > >> in qemu-kvm? Some switches are lacking deprecated warnings on the > >> console, and -no-kvm is missing completely. I tend to focus on patch 1 & > >> 5, dropping the rest - based on relevance for production use. > > > > The distros need to keep these flags to do the switch. > > Why? Should be documented in commit log. > > > I see no point > > in deprecating them since they're trivially easy to maintain. > > Given the level of cr** we already have in the command line, they are > kind of noise, yes. But even then, these patches are not consistent as > pointed out above. > > Also, they should not be documented to avoid being spread. That's what > we did with other deprecated switches in QEMU. > > Jan Jan, You're comments to the patch are: - No documentation. - Expiration date. - Changelog explaining what?? (didnt get that). Perhaps better changelog in general? Please help me understand.